Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/404/70x/20240417/v1 #10886

Merged
merged 2 commits into from
Apr 17, 2024
Merged

next/404/70x/20240417/v1 #10886

merged 2 commits into from
Apr 17, 2024

Conversation

victorjulien
Copy link
Member

@catenacyber
conf: avoid quadratic complexity
26a5357 
Ticket: 6878

Follow up on 1564942

When adding many sequence nodes, either from start or scalar event

We add "sequence nodes" whose name is an integer cf sequence_node_name
and then run ConfNodeLookupChild to see if it had been already set
(from the command line cf comment in the code)
And ConfNodeLookupChild iterates the whole linked list...

1. We add node 1
2. To add node 2, we check if node 1 equals this new node
3. To add node 3, we check if nodes 1, or 2 equals this new node's name
And so on...

This commits avoids these checks ig the list is empty at the beginning

(cherry picked from commit 240e068)
@catenacyber @victorjulien
ci: clean some disk space to run CIFuzz again
5267479 
(cherry picked from commit 365a66a)
@victorjulien victorjulien requested a review from jasonish as a code owner April 17, 2024 15:58
@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 20121

@victorjulien victorjulien merged commit 5267479 into OISF:main-7.0.x Apr 17, 2024
42 checks passed
This was referenced Apr 17, 2024
Merged
Closed
@victorjulien victorjulien deleted the next/404/70x/20240417/v1 branch April 17, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonish jasonish jasonish approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@victorjulien @suricata-qa @jasonish @catenacyber