-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert byte_extract keyword parser to Rust #10881
Conversation
Issue: 6873 Refactor the enums for endian and base handling for broader use.
Implement the keyword parser in Rust. Issue: 6831
This commit uses Option instead of Result. Issue: 6831
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10881 +/- ##
==========================================
- Coverage 82.95% 82.85% -0.10%
==========================================
Files 917 922 +5
Lines 247367 247685 +318
==========================================
+ Hits 205198 205219 +21
- Misses 42169 42466 +297
Flags with carried forward coverage won't be shown. Click here to find out more. |
Information: QA ran without warnings. Pipeline 20129 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work Jeff
CI : 🟢
Code : Checking now
Commits segmentation : Could last commit get squashed ?
Commit messages : The redmine ticket 6873 should be mentioned in the commit detect/byte_extract: Move keyword parser to Rust
Git ID set : looks fine for me
CLA : :-p
Doc update : not needed
Redmine ticket : Is https://redmine.openinfosecfoundation.org/issues/6831 handled here ?
Rustfmt : Could you run it to have 2 small changes in byte_extract.rs and byte_math.rs ?
Tests : ok
Dependencies added: none added
Continued in #10906 |
Continuation of #10833
Convert the byte_extract option parser from C to Rust.
Link to redmine ticket: 6873
Describe changes:
Updates:
Provide values to any of the below to override the defaults.
To use a pull request use a branch name like
pr/N
whereN
is thepull request number.
Alternatively,
SV_BRANCH
may also be a link to anOISF/suricata-verify pull-request.