Clippy 177 v2 #10691
Merged
Clippy 177 v2 #10691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 6883 error: field `0` is never read --> src/asn1/mod.rs:36:14 | 36 | BerError(Err<der_parser::error::BerError>), | -------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | field in this variant |
error: unnecessary use of `to_vec`
--> src/smb/smb.rs:1048:62
|
1048 | let (name, is_dcerpc) = match self.guid2name_map.get(&guid.to_vec()) {
| ^^^^^^^^^^^^^^ help: replace it with: `guid`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned
= note: `#[deny(clippy::unnecessary_to_owned)]` implied by `#[deny(warnings)]`
And also other uses of to_vec() on already Vec
victorjulien
approved these changes
Mar 21, 2024
jasonish
approved these changes
Mar 21, 2024
Merged
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10691 +/- ##
==========================================
- Coverage 82.72% 82.66% -0.07%
==========================================
Files 926 926
Lines 247633 247633
==========================================
- Hits 204865 204714 -151
- Misses 42768 42919 +151
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Merged in #10693, thanks! |
This was referenced Mar 21, 2024
Closed
This was referenced Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6883
Describe changes:
And get CI green again
#10690 + second commit