Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next/284/20240210/v1 #10359

Merged
merged 4 commits into from
Feb 12, 2024
Merged

Conversation

jtstrs and others added 4 commits February 10, 2024 22:29
Fix memory leak at util-decode-mime:MimeDecInitParser, which
root cause is not-freeing allocated memory for mimeMsg

Bug: OISF#6745
Issue: 6755

When NetmapOpen encounters an error opening the netmap device, it'll
retry a bit. When the retry limit is reached, it'll shutdown Suricata.

This commit ensures that the device list lock is not held when before
closing all open devices before terminating Suricata.
Issue: 6712

Remove multiple occurrences of libjansson installation packages.
Copy link

NOTE: This PR may contain new authors.

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7e4dba7) 82.32% compared to head (9fe00ff) 82.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10359      +/-   ##
==========================================
+ Coverage   82.32%   82.52%   +0.19%     
==========================================
  Files         978      978              
  Lines      272147   272148       +1     
==========================================
+ Hits       224057   224588     +531     
+ Misses      48090    47560     -530     
Flag Coverage Δ
fuzzcorpus 63.59% <0.00%> (-0.01%) ⬇️
suricata-verify 61.87% <0.00%> (+0.37%) ⬆️
unittests 62.83% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 18318

Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@victorjulien victorjulien merged commit 9fe00ff into OISF:master Feb 12, 2024
45 checks passed
@victorjulien victorjulien deleted the next/284/20240210/v1 branch February 12, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants