Stats schema update/v5 #10348
Closed
Stats schema update/v5 #10348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket 6434
Ticket 6434
Ticket 6434
inashivb
force-pushed
the
stats-schema-update/v5
branch
from
04a2a09 to
d2bd472
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10348 +/- ##
==========================================
- Coverage 82.32% 82.32% -0.01%
==========================================
Files 978 978
Lines 272147 272147
==========================================
- Hits 224057 224046 -11
- Misses 48090 48101 +11
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
requested changes
Feb 12, 2024
| "type": "integer" | ||
| }, | ||
| "app_layer": { | ||
| "type": "object", | ||
| "properties": { | ||
| "expectations": { | ||
| "description": "Expectation (dynamic parallel flow) counter", |
There was a problem hiding this comment.
what is 'dynamic parallel flow'? Its not something we refer to anywhere else?
There was a problem hiding this comment.
I think I read it in the code as the definition of expectation. See: https://github.com/OISF/suricata/blob/master/src/app-layer-expectation.c#L26
Do you propose this to be removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of some stats params.
Can be merged as-is once approved or we can wait for other stats updates too.
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/6434
Previous PR: #10324
Changes since v3: