Add tests for packet_alert_max - v3 #743
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the default max alert value is 15 and we want to ensure that value is enforced if the configuration is set with something invalid, this test has packet-max-alert set to 0 (which will fall back to 15, the default). Task #4942
This was referenced Feb 14, 2022
|
Related work still needed: test to ensure alert order doesn't change. (but the S-V tests in this PR work on its on) |
|
Followed by #782 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR: #694
Changes:
Related to https://redmine.openinfosecfoundation.org/issues/4207
and https://redmine.openinfosecfoundation.org/issues/4942
Also reworded (and changed!!) first commit a bit, (sorry, that shouldn't have been done, right).
Goes with Suricata PR OISF/suricata#7000