tests: pcrexform tests #196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds tests for the `pcrexform` including tests for - basic functionality: Simple PCRE - extended functionality: Multiple PCREs - Negative: PCRE that do not match anything - Negative: Missing option values
Closed
This was referenced May 2, 2020
catenacyber
added
tests pass
catenacyber
requested changes
Jul 31, 2020
| @@ -0,0 +1,8 @@ | |||
| requires: | |||
|
|
|||
There was a problem hiding this comment.
Should we set a min-version of 6.0 ?
There was a problem hiding this comment.
Thanks for pointing this out. I'll update the requires section
Closed
|
Continued in #285 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for the
pcrexformincluding tests forSuricata PR #4651