Fix bug in LoadProperty for complex and complex collection

[gathogojr]

Issues

This pull request fixes #2471.

Description

We rely on ODataLoadNavigationPropertyMaterializer to materialize load property result for complex and complex collection property. Complex and complex collection properties are structural properties, the reliance on ODataLoadNavigationPropertyMaterializer is by design - we use ODataReaderEntityMaterializer as well to materialize complex and complex collection properties, since just like entities, they're returned as ODataResource.
The bug was in how we apply the materialized values to the respective properties on the client type instance.
Due to a missing condition check, the complex collections were being treated as if they are a single entity value.

I fixed the bug by applying the missing check. By doing so, this block in LoadPropertyResult class does the job of applying the complex collection to the property - after first clearing the existing items.

Checklist (Uncheck if it is not completed)

• Test cases added
• Build and test with one-click build and test script passed

Additional work necessary

If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.

[habbes]

In which block do complex properties and/or complex collection properties get handled?

[gathogojr]

@habbes This block

odata.net/src/Microsoft.OData.Client/LoadPropertyResult.cs

Line 220 in 4e263ca

else if (property.IsPrimitiveOrEnumOrComplexCollection)

[xuzhg]

shall we put the new test file under "Materialization" subfolder?

[gathogojr]

@xuzhg Done

[pull-request-quantifier-deprecated]

This PR has 275 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

---

Quantification details

Label      : Large
Size       : +273 -2
Percentile : 67.5%

Total files changed: 3

Change summary by file extension:
.cs : +272 -2
.csproj : +1 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

• Fast and predictable releases to production:
  • Optimal size changes are more likely to be reviewed faster with fewer
    iterations.
  • Similarity in low PR complexity drives similar review times.
• Review quality is likely higher as complexity is lower:
  • Bugs are more likely to be detected.
  • Code inconsistencies are more likely to be detected.
• Knowledge sharing is improved within the participants:
  • Small portions can be assimilated better.
• Better engineering practices are exercised:
  • Solving big problems by dividing them in well contained, smaller problems.
  • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

• Use the PullRequestQuantifier to quantify your PR accurately
  • Create a context profile for your repo using the context generator
  • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
  • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
  • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
• Change your engineering behaviors
  • For PRs that fall outside of the desired spectrum, review the details and check if:
    • Your PR could be split in smaller, self-contained PRs instead
    • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

• One line was added: +1 -0
• One line was deleted: +0 -1
• One line was modified: +1 -1 (git diff doesn't know about modified, it will
  interpret that line like one addition plus one deletion)
• Change percentiles: Change characteristics (addition, deletion, modification)
  of this PR in relation to all other PRs within the repository.

---

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.