Added writer setting to add type annotations #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added 'AlwaysAddTypeAnnotationsForDerivedTypes' to ODataMessageWriterSettings * Chagned JsonNoMetadataLevel to use 'JsonMinimalMetadataTypeNameOracle' when 'AlwaysAddTypeAnnotationsForDerivedTypes' is setting * Updated unit tests
xuzhg
reviewed
Dec 9, 2020
xuzhg
reviewed
Dec 9, 2020
xuzhg
reviewed
Dec 9, 2020
xuzhg
reviewed
Dec 9, 2020
test/FunctionalTests/Microsoft.OData.Core.Tests/JsonLight/JsonLightMetadataLevelTests.cs
Outdated
Show resolved
Hide resolved
xuzhg
reviewed
Dec 9, 2020
test/FunctionalTests/Microsoft.OData.Core.Tests/JsonLight/JsonNoMetadataLevelTests.cs
Show resolved
Hide resolved
xuzhg
reviewed
Dec 9, 2020
test/FunctionalTests/Microsoft.OData.Core.Tests/JsonLight/JsonNoMetadataLevelTests.cs
Show resolved
Hide resolved
mikepizzo
approved these changes
Dec 9, 2020
xuzhg
reviewed
Dec 14, 2020
| @@ -24,10 +24,25 @@ internal abstract class JsonLightMetadataLevel | |||
| /// </summary> | |||
| /// <param name="mediaType">The full media type being written. This media type must have a type/subtype of "application/json".</param> | |||
| /// <param name="metadataDocumentUri">The metadata document uri from the writer settings.</param> | |||
| /// <param name="alwaysAddTypeAnnotationsForDerivedTypes">When set, type annotations will be added for derived types, even when the metadata level is set to "None".</param> | |||
There was a problem hiding this comment.
alwaysAddTypeAnnotationsForDerivedTypes [](start = 25, length = 39)
should remove this param #Resolved
There was a problem hiding this comment.
Both model and writingResponse appear to have appropriate docs:
There was a problem hiding this comment.
Updated to remove incorrect alwaysAddTypeAnnotationsForDerivedTypes doc comment. #Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes issue #1945.
Description
Added 'AlwaysAddTypeAnnotationsForDerivedTypes' to ODataMessageWriterSettings
Chagned JsonNoMetadataLevel to use 'JsonMinimalMetadataTypeNameOracle' when 'AlwaysAddTypeAnnotationsForDerivedTypes' is setting
Updated unit tests
Checklist (Uncheck if it is not completed)