downgrade the System.Text.Json package reference version #1880
Conversation
xuzhg
force-pushed
the
downgradeSystemTextJsonVersion
branch
from
3ecaff7 to
e38b1e4
Compare
xuzhg
force-pushed
the
downgradeSystemTextJsonVersion
branch
from
e38b1e4 to
257ed02
Compare
xuzhg
changed the title
xuzhg
added
the
Ready for review
| <PackageReference Include="System.Text.Json"> | ||
| <Version>4.7.1</Version> | ||
| </PackageReference> | ||
| <PackageReference Include="System.Text.Json" Version="4.*" /> |
There was a problem hiding this comment.
@xuzhg Curious how Version="4.*" is interpreted. Wouldn't 4.7.1 be validated against 4.*?
There was a problem hiding this comment.
Here's the context:
Floating versions
A floating dependency version is specified with the * character. For example, 6.0.. This version specification says "use the latest 6.0.x version"; 4. means "use the latest 4.x version." Using a floating version reduces changes to the project file, while keeping up to date with the latest version of a dependency.
When using a floating version, NuGet resolves the highest version of a package that matches the version pattern, for example 6.0.* gets the highest version of a package that starts with 6.0:
Choosing version 6.0.1 when a floating version 6.0.* is requested
There was a problem hiding this comment.
@gathogojr Besides, I use this PR and output a nightly, That nightly can be used directly without the build error.
There was a problem hiding this comment.
@xuzhg Got it. So having the version pinned to 4.7.1 was the issue
|
@xuzhg Any idea why ADO is reporting building failure for [OData-master-pipeline-Rolling] in spite of this: |
|
@xuzhg are the builds failing as a result of this change? |
No, i run the rolling manually, it can pass. See https://identitydivision.visualstudio.com/OData/_build/results?buildId=621841&view=results |
Issues
This pull request fixes issue #1878.
Description
Briefly describe the changes of this pull request.
Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.