Reduce warnings across projects #1808
Conversation
| return Microsoft.OData.Edm.EdmRes.GetString(Microsoft.OData.Edm.EdmRes.Constructable_VocabularyAnnotationMustHaveTarget); | ||
| } | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// A string like "An entity type or a collection of an entity type or a complex type is expected." | ||
| /// A string like "An entity type or a collection of an entity type is expected." |
There was a problem hiding this comment.
Why did this string change?
There was a problem hiding this comment.
This file is auto generated. I simply executed the tt script. I don't know what else to tell you. :)
| { | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
why remove this codes? It's unsafe?
There was a problem hiding this comment.
See https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1063?view=vs-2019 on how to implement IDisposable correctly.
The Dispose method should have the code below, and only the code below. Any additional cleanup must be performed by Dispose(bool disposing).
public void Dispose()
{
this.Dispose(true);
GC.SuppressFinalize(this);
}There was a problem hiding this comment.
@gathogojr @g2mula What do you think?
| /// </summary> | ||
| internal sealed class EdmRes { | ||
| internal const string EdmPrimitive_UnexpectedKind = "EdmPrimitive_UnexpectedKind"; | ||
| internal const string EdmPath_UnexpectedKind = "EdmPath_UnexpectedKind"; | ||
| internal const string Annotations_TypeMismatch = "Annotations_TypeMismatch"; | ||
| internal const string Constructable_VocabularyAnnotationMustHaveTarget = "Constructable_VocabularyAnnotationMustHaveTarget"; | ||
| internal const string Constructable_EntityTypeOrCollectionOfEntityTypeOrComplexTypeExpected = "Constructable_EntityTypeOrCollectionOfEntityTypeOrComplexTypeExpected"; | ||
| internal const string Constructable_EntityTypeOrCollectionOfEntityTypeExpected = "Constructable_EntityTypeOrCollectionOfEntityTypeExpected"; |
There was a problem hiding this comment.
Constructable_EntityTypeOrCollectionOfEntityTypeExpected [](start = 30, length = 56)
It's weird, we don't need to change Microsoft.OData.Edm.txt file?
There was a problem hiding this comment.
I'm unfamiliar with these files. I simply executed the tt script. If that is not enough, let me know!
This file and Microsoft.OData.Edm.cs is autogenerated from "Microsoft.OData.Edm.txt" and "......tt" file, Do you right click the "... tt" file and auto generate it? #Resolved Refers to: src/Microsoft.OData.Edm/Parameterized.Microsoft.OData.Edm.cs:21 in 5b22550. [](commit_id = 5b22550, deletion_comment = True) |
Typically, we should ignore "Microsoft.OData.Edm.cs" and "Paramer.....Microsoft.OData.Edm.s" for the styleCop. We can do like this:
If we don't want to ignore them, please modify the template file and make sure the output meets the stylecop. Refers to: src/Microsoft.OData.Edm/Microsoft.OData.Edm.cs:11 in 5b22550. [](commit_id = 5b22550, deletion_comment = False) |
| @@ -207,8 +207,10 @@ namespace <#= Configuration.ResourceClassNamespace #> { | |||
| private void GenerateAsProperty(string id) | |||
| { | |||
| #> | |||
| internal static string <#= id #> { | |||
| get { | |||
|
It looks good. I'd like to merge it ASAP. However, there's one change confusing me. I left a comment at ODataInputContext.cs, please take a look and address that. |
xuzhg
added
the
Ready for review
…ginExecute{TElement}.
|
@bdebaere Since you are adding more commits, Ping me when done so that we can review this PR |
@KenitoInc I'm done now. |
Fix CA1200: replace cref="\w: with cref=".
Fix xUnit2017: replace Assert.IsTrue(Contains) with Assert.Contains.
Fix CA1063: implement Dispose correctly.
Fix CA1309: use StringComparison.Ordinal.
Fix CA1507: use nameof instead of string literal.
Fix CS1658: replace `1 with generic parameter in comments.
Fix SA1500: adjust StringsClassGenerator.ttinclude to span multiple lines.