update read write timeout value when timeout value is set #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElizabethOkerio
force-pushed
the
fix/update_read_and_write_timeout_properties_when_request_timeout_is_set
branch
from
289646a to
ba04778
Compare
xuzhg
added
the
Ready for review
marabooy
reviewed
Jun 3, 2020
odero
reviewed
Jun 3, 2020
g2mula
reviewed
Jun 3, 2020
src/Microsoft.OData.Client/Serialization/HttpWebRequestMessage.cs
Outdated
Show resolved
Hide resolved
ElizabethOkerio
force-pushed
the
fix/update_read_and_write_timeout_properties_when_request_timeout_is_set
branch
from
415e30b to
5bd4892
Compare
g2mula
reviewed
Jun 8, 2020
| } | ||
| set | ||
| { | ||
| this.client.Timeout = new TimeSpan(0, 0, value); |
There was a problem hiding this comment.
Needs an summary documentation explaining the timeout is in seconds.
...alTests/Tests/DataServices/UnitTests/ClientExtensions/TestDataServiceClientRequestMessage.cs
Show resolved
Hide resolved
xuzhg
approved these changes
Jun 9, 2020
| @@ -115,6 +115,9 @@ public class DataServiceContext | |||
| #if !PORTABLELIB // Timeout not available | |||
| /// <summary>time-out value in seconds, 0 for default</summary> | |||
| private int timeout; | |||
There was a problem hiding this comment.
what's the difference between "timeout" and "readWriteTimeout" ?
There was a problem hiding this comment.
timeout is the number of milliseconds to wait before the request(basically the connection) timesout while readWriteTimeout is the number of milliseconds to wait before the writing/reading of a request/response timeouts.
odero
approved these changes
Jun 9, 2020
chrisspre
reviewed
Jun 10, 2020
| /// The value may be changed between requests to a data service and the new value | ||
| /// will be picked up by the next data service request. | ||
| /// </remarks> | ||
| public virtual int ReadWriteTimeout |
There was a problem hiding this comment.
Why wouldn't this be a TimeSpan? This creates no confusion, removes the need to mention seconds or convert it.
Sreejithpin
approved these changes
Jun 10, 2020
ElizabethOkerio
force-pushed
the
fix/update_read_and_write_timeout_properties_when_request_timeout_is_set
branch
from
c7df31e to
d4fc201
Compare
ElizabethOkerio
force-pushed
the
fix/update_read_and_write_timeout_properties_when_request_timeout_is_set
branch
from
d4fc201 to
f7bd66b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes issue #1753.
Description
Currently, It is not possible to set the ReadWriteTimeout property of a request in
Microsoft.OData.Clientbut you can set the Timeout property. This means that each request uses the defaultHttpWebRequest ReadWriteTimeoutproperty which is 300seconds or 5 minutes.If an endpoint takes more than 5 minutes to return a response to
Microsoft.OData.Clientthat response will not be received and processed byMicrosoft.OData.Client. This is because the ReadWriteTimeout property times out after 5 mins hence the ReadWrite connection times out.Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.