-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
different null validation messages for complex and primitive collections #1793
Conversation
16cfdea
to
db2720e
Compare
src/Microsoft.OData.Core/JsonLight/ODataJsonLightPropertyAndValueDeserializer.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test to document/show this?
b6483e6
to
58876e8
Compare
test/FunctionalTests/Microsoft.OData.Core.Tests/NavigationPropertyOnComplexTests.cs
Show resolved
Hide resolved
test/FunctionalTests/Microsoft.OData.Core.Tests/NavigationPropertyOnComplexTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some tests are failing.
src/Microsoft.OData.Core/JsonLight/ODataJsonLightPropertyAndValueDeserializer.cs
Outdated
Show resolved
Hide resolved
c4bc7ae
to
01db728
Compare
src/Microsoft.OData.Core/JsonLight/ODataJsonLightResourceDeserializer.cs
Outdated
Show resolved
Hide resolved
01db728
to
7e98502
Compare
c8a37cf
to
c411429
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
58b526f
to
cc089bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cc089bd
to
2143f74
Compare
Issues
This pull request fixes issue #1715.
Description
The error message returned by the null validation of a collection of primitive values and a collection of complex values is different. The expected result is for the error message for the null validation of both collections to be the same.
A null collection of primitive values returns this error message:
while a null collections of complex values returns:
The expected result is for the error message for both collections to be:
Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.