migrate odata client tests to xUnit #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElizabethOkerio
force-pushed
the
fix/migrate_odata_client_tests_to_xunit
branch
from
800d9b6 to
e95fef9
Compare
ElizabethOkerio
force-pushed
the
fix/migrate_odata_client_tests_to_xunit
branch
from
b55c943 to
162362e
Compare
ElizabethOkerio
force-pushed
the
fix/migrate_odata_client_tests_to_xunit
branch
from
162362e to
9790cf2
Compare
ElizabethOkerio
added
the
Ready for review
ElizabethOkerio
requested review from
xuzhg,
odero,
gathogojr,
habbes,
g2mula,
marabooy,
paulodero,
KenitoInc,
wandeg and
wachugamaina
|
please rebase to latest master, make build pass and merge with squash |
odero
approved these changes
Jun 19, 2020
| @@ -105,7 +105,7 @@ public async Task SaveChangesTest() | |||
| customers.Add(c2); | |||
|
|
|||
| var dataServiceResponse = await context.SaveChangesAsync(SaveChangesOptions.BatchWithIndependentOperations | SaveChangesOptions.UseRelativeUri); | |||
| Assert.Equal((dataServiceResponse.First() as ChangeOperationResponse).StatusCode, 201); | |||
| Assert.Equal(201, (dataServiceResponse.First() as ChangeOperationResponse).StatusCode); | |||
There was a problem hiding this comment.
While you're here, you might want to use the HttpStatusCode Enum, for readability
https://docs.microsoft.com/en-us/dotnet/api/system.net.httpstatuscode
| #else | ||
| using Microsoft.VisualStudio.TestTools.UnitTesting; | ||
|
|
||
| #endif | ||
| #if !PORTABLELIB && !SILVERLIGHT |
There was a problem hiding this comment.
Possible to remove these portablelib silverlight references while you are doing this?
| Assert.AreEqual(string.Format("{0}.AddressType", TestModelNameSpace), annotationOnHomeAddress.Name); | ||
| Assert.AreEqual("Home", (annotationOnHomeAddress.Value as ODataPrimitiveValue).Value); | ||
| Assert.Equal(string.Format("{0}.AddressType", TestModelNameSpace), annotationOnHomeAddress.Name); | ||
| Assert.Equal("Home", (annotationOnHomeAddress.Value as ODataPrimitiveValue).Value); | ||
|
|
||
| // TODO : Fix #625 |
There was a problem hiding this comment.
Could you check on this issue and probably close if it's been resolved?
...dToEndTests/Tests/Client/Build.Desktop/BatchRequestTests/BatchRequestWithRelativeUriTests.cs
Show resolved
Hide resolved
test/EndToEndTests/Tests/Client/Build.Desktop/ClientTests/ClientUpdateTests.cs
Show resolved
Hide resolved
test/EndToEndTests/Tests/Client/Build.Desktop/ClientTests/ClientUpdateTests.cs
Show resolved
Hide resolved
| public void ServiceOperationFeedQuery() | ||
| { | ||
| var contextWrapper = this.CreateContext(); | ||
| var queryResult = contextWrapper.Execute<Customer>(new Uri(this.ServiceUri.OriginalString + "/GetSpecificCustomer?Name='enumeratetrademarkexecutionbrfalsenesteddupoverflowspacebarseekietfbeforeobservedstart'"), "GET", true).ToArray(); | ||
| Assert.AreEqual(1, queryResult.Count(), "Expected a single Customer return"); | ||
| Assert.Equal(1, queryResult.Count()); |
There was a problem hiding this comment.
Suggested change
| Assert.Equal(1, queryResult.Count()); | |
| Assert.Single(queryResult); | |
There was a problem hiding this comment.
xunit recommends the use of Single for a collection with a count of 1.
There was a problem hiding this comment.
Isn't that what this is? Or does it have to be a List (with a .Count prop) as opposed to just an IEnumerable?
Sreejithpin
approved these changes
Jun 24, 2020
| } | ||
| } | ||
| } | ||
|
|
||
| private static void AssertODataCollectionValueAreEqual(ODataCollectionValue expectedCollectionValue, ODataCollectionValue actualCollectionValue) |
There was a problem hiding this comment.
Do we need to change Method name also (doesnt harm though)? I guess you would have done a Cntrl+H ?
ElizabethOkerio
force-pushed
the
fix/migrate_odata_client_tests_to_xunit
branch
from
14d8b45 to
2828009
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes issue #xxx.
Description
Briefly describe the changes of this pull request.
Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.