-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DataServiceContext can't work with POCO's due to Missing IEdmModel #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzhg
reviewed
Jan 2, 2020
odero
reviewed
Jan 8, 2020
4b978b4
to
0e32792
Compare
g2mula
reviewed
Jan 27, 2020
odero
requested changes
Jan 31, 2020
...Tests/Tests/DataServices/UnitTests/Client.TDD.Tests/Tests/CustomizedHttpWebRequestMessage.cs
Outdated
Show resolved
Hide resolved
...FunctionalTests/Tests/DataServices/UnitTests/Client.TDD.Tests/Tests/ClientSerializerTests.cs
Outdated
Show resolved
Hide resolved
...Tests/Tests/DataServices/UnitTests/Client.TDD.Tests/Tests/CustomizedHttpWebRequestMessage.cs
Outdated
Show resolved
Hide resolved
...nctionalTests/Tests/DataServices/UnitTests/Client.TDD.Tests/Tests/DataServiceContextTests.cs
Outdated
Show resolved
Hide resolved
...s/DataServices/UnitTests/Client.TDD.Tests/Tests/Serialization/ODataWriterWrapperUnitTests.cs
Outdated
Show resolved
Hide resolved
...ctionalTests/Tests/DataServices/UnitTests/Client.TDD.Tests/Tests/T4/ODataT4CamelCaseTests.cs
Show resolved
Hide resolved
...aServices/UnitTests/ClientCSharpUnitTests/DataWebClientCSharp/ClientCSharpRegressionTests.cs
Outdated
Show resolved
Hide resolved
g2mula
reviewed
Feb 3, 2020
...tTests/ClientCSharpUnitTests/DataWebClientCSharp/ClientErrorHandlingShortIntegrationTests.cs
Show resolved
Hide resolved
test/FunctionalTests/Tests/DataServices/UnitTests/ClientUnitTests/ClientRegressionTests.vb
Outdated
Show resolved
Hide resolved
test/FunctionalTests/Tests/DataServices/UnitTests/ClientUnitTests/StateManagementTests.vb
Show resolved
Hide resolved
habbes
reviewed
Feb 3, 2020
habbes
approved these changes
Feb 18, 2020
odero
approved these changes
Feb 20, 2020
habbes
approved these changes
Feb 26, 2020
marabooy
added a commit
to marabooy/OData-docs
that referenced
this pull request
Feb 27, 2020
marabooy
added a commit
to marabooy/OData-docs
that referenced
this pull request
Feb 27, 2020
marabooy
added a commit
to marabooy/OData-docs
that referenced
this pull request
Feb 27, 2020
7aa1218
to
8014da3
Compare
…rk for certain cases and updated tests and regression tests for failing test cases
…ponse using hooks Sorted namespaces in the committed files
8014da3
to
0b3cb92
Compare
KanishManuja-MS
pushed a commit
to KanishManuja-MS/odata.net
that referenced
this pull request
Mar 24, 2020
OData#1614) Added changes to DataServiceClientFormat to load edm model from network for certain cases and updated tests and regression tests for failing test cases Closes OData#1003
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
*This pull request fixes issue #1003 *
Description
Introduces a new action to load the metadata from the metadata Url and set the ServiceModel. The new action runs to load the metadata if the metadata had not been set before (directly by calling
context.Format.UseJson(ServiceModel)
or using a user provided Hookcontext.Format.LoadServiceModel
.This would allow people to use the syntax below to use this method in their code when not using the code generation tools or when they want to use the latest model in their code. E.g when developing new API's or when working on API's that do not publish breaking changes.
This does not negatively impact client code generated using the tools (codegen and connected service) as they provide the ServiceModel directly or provide a Hook using the exposed
context.Format.LoadServiceModel
property. Existing users of OData Client also needed to have the service model set in order for it to function properly.Checklist (Uncheck if it is not completed)
Additional work necessary
Docs Needed