Use the array pool in Json writer #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ysanghi Would you please also take a look this PR? thanks. |
xuzhg
added
the
Ready for review
raheph
reviewed
Mar 14, 2019
| @@ -23,12 +23,23 @@ internal static class BufferUtils | |||
| /// <returns>The initialized buffer</returns> | |||
| public static char[] InitializeBufferIfRequired(char[] buffer) | |||
| { | |||
| if (buffer == null) | |||
| return InitializeBufferIfRequired(null, buffer); | |||
There was a problem hiding this comment.
Why do we need this method? can't we do something like this?
if (buffer == null) {
return RentFromBuffer(null, buffer);
}
return buffer;
There was a problem hiding this comment.
That's avoiding a duplicated code. At later, if we change something, we only change the second method, don't need to change all methods. Thanks.
There was a problem hiding this comment.
mikepizzo
reviewed
Mar 19, 2019
| @@ -392,6 +398,7 @@ public void WriteRawValue(string rawValue) | |||
| /// </summary> | |||
| public void Flush() | |||
| { | |||
| BufferUtils.ReturnToBuffer(this.ArrayPool, this.buffer); | |||
| this.writer.Flush(); | |||
There was a problem hiding this comment.
Should we return to pool on Flush or Dispose? #Closed
There was a problem hiding this comment.
@mikepizzo I changed to use the "Dispose". #Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Description
Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.