Make aliases created in compute() transformation visible for following transforms/query options #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzhg
approved these changes
Jan 7, 2019
| token.Kind.ShouldBeEquivalentTo(QueryTokenKind.Compute); | ||
| List<ComputeExpressionToken> tokens = token.Expressions.ToList(); | ||
| tokens.Count.Should().Be(3); | ||
| tokens[0].Kind.ShouldBeEquivalentTo(QueryTokenKind.ComputeExpression); |
There was a problem hiding this comment.
Maybe it's more clear to create a private method to verify # 1, # 2, # 3 separately.
There was a problem hiding this comment.
We have test ParseComputeWithMathematicalOperations that checks $compute for that case. I'm adding the same for compute()
...lTests/Microsoft.OData.Core.Tests/ScenarioTests/UriParser/FilterAndOrderByFunctionalTests.cs
Outdated
Show resolved
Hide resolved
...lTests/Microsoft.OData.Core.Tests/ScenarioTests/UriParser/FilterAndOrderByFunctionalTests.cs
Show resolved
Hide resolved
xuzhg
added
the
Ready for review
xuzhg
pushed a commit
to xuzhg/odata.net
that referenced
this pull request
Feb 14, 2019
…g transforms/query options (OData#1369) * Ensure that we can use aliases genearted in compute on later stages * Ensure that we can use aliases genearted in compute on later stages * Extra tests for compute * Code alignment
xuzhg
pushed a commit
that referenced
this pull request
Feb 14, 2019
…g transforms/query options (#1369) * Ensure that we can use aliases genearted in compute on later stages * Ensure that we can use aliases genearted in compute on later stages * Extra tests for compute * Code alignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
*This pull request fixes issue #1368 * also adds a few tests for ApplyBinder (it wasn't covered in original implementation)
Description
Collecting aliases generated in compute() transformation to make them visible for following transformations and/or query options ($orderby, $filter)
Checklist (Uncheck if it is not completed)