Fix threadsafety in DataServiceClient EntityTracker's internal dictionary #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrentDictionary<> objects instead.
mikepizzo
changed the title
|
@mikepizzo The branch threadsafety-1043 was created in the master repo, but it is supposed to be a branch in your forked repo. Can you please re-create it (git push <mikep's origin> branch-name) so that CI build can be done? |
biaol-odata
reviewed
Jun 26, 2018
| @@ -85,6 +86,23 @@ internal static class DictionaryExtensions | |||
|
|
|||
| return false; | |||
| } | |||
| #else | |||
| /// <summary> | |||
| /// Convenience function that wraps ConcurrentDictionary.TryAdd() to allow same signature as IDictionary | |||
There was a problem hiding this comment.
nit: Add <throws> to note the difference between the underneath TryAdd?
update: <throws> (escaped brackets)
biaol-odata
reviewed
Jun 26, 2018
|
PR #1200 moves this to separate branch for CI to work correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes issue #1043 and is a resubmit of PR #1054 with CR comments addressed.
Description
Replaces EntityTracker's internal Dictionary<> objects with thread-safe ConcurrentDictionary<> ones.
Checklist (Uncheck if it is not completed)
Test cases added
Build and test with one-click build and test script passed