Add nuget package testing. #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanWong-MS
reviewed
Feb 15, 2018
| <WarningLevel>4</WarningLevel> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <Reference Include="Microsoft.OData.Client, Version=7.4.0.20111, Culture=neutral, PublicKeyToken=31bf3856ad364e35"> |
There was a problem hiding this comment.
CR note: the hardcode here will be updated during automation
There was a problem hiding this comment.
Correct. However, it makes sense to checkin a lower version, say 7.0.0. Automation will update it but never checkin the update. I'll make a change here...
There was a problem hiding this comment.
Agreed, that would be cleaner.
There was a problem hiding this comment.
Changed. Core, Edm and Spatial point to 7.0.0, Client points to 7.4.0 since that is the earliest 7.x RTM version of the client.
AlanWong-MS
approved these changes
Feb 15, 2018
This intention is to provide a small test project that can ingest the latest NuPkg's from the build, restore them, build the project which results in a testable Dll. These tests are very limited in scope, i.e. they only test the Dlls ability to load and perform basic functions; the functional tests will test the full functionality.
robward-ms
force-pushed
the
master-NugetTest
branch
from
7d1448d to
8505d3f
Compare
AlanWong-MS
approved these changes
Feb 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This intention is to provide a small test project that can ingest the latest NuPkg's
from the build, restore them, build the project which results in a testable Dll. These
tests are very limited in scope, i.e. they only test the Dlls ability to load and
perform basic functions; the functional tests will test the full functionality.
Checklist (Uncheck if it is not completed)
Additional work necessary
An additional build task will need to be added to update/compile/test this code.