Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODL 7.16.0 makes ASP OData build hang-on #1012

Closed
wants to merge 1 commit into from
Closed

Conversation

xuzhg
Copy link
Member

@xuzhg xuzhg commented Aug 8, 2023

Let's update to ODL 7.17.0

Let's update to ODL 7.17.0
Copy link
Contributor

@gathogojr gathogojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@mikepizzo mikepizzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xuzhg -- Do we know what about ODL 7.16 makes the ASP OData build hang? Is there a debug assert raised by ODL, or an issue that an app would encounter calling the release ODL 7.16?

@xuzhg
Copy link
Member Author

xuzhg commented Aug 8, 2023

@xuzhg -- Do we know what about ODL 7.16 makes the ASP OData build hang? Is there a debug assert raised by ODL, or an issue that an app would encounter calling the release ODL 7.16?

@mikepizzo , thanks for reviewing.
I assumed it could be related to ODL commits and Checked with @ElizabethOkerio, it could be related to:

OData/odata.net#2670
OData/odata.net#2671

However, the build is still hang on. I will continue to follow up it.

@xuzhg
Copy link
Member Author

xuzhg commented Aug 8, 2023

It seems it is related to #1013

The root cause is:
In an asysc test case, we can an async method using sync pattern. It's blocking the test running.

@xuzhg xuzhg closed this Aug 8, 2023
@xuzhg xuzhg deleted the updateToODL7170 branch August 14, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants