cropper sanity #84
Merged
cropper sanity #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… recursively (not just outer) and use exact contour area (without drawing to intermediate image)
- use margin parameters in places where this was forgotten - add margin parameter for top side - edge/textline detector based heuristic: fix right/bottom margin criterion - sane identifiers, code readibility - optional debug images for most steps
- instead of fake/coarse approximations, cluster and aggregate line segments by - using linear regressors for grouping and representation - joining nearby points (if linearly consistent) - joining similar groups (if consistent and no gaps between) - instead of crude selection heuristics, filter line groups such that candidates - have minimum total length - range over non-margin area - reside in margin-area - instead of just innermost result, choose candidate with both largest length and inner-most position on each side
…moving small ones
… bbox, and pad it inwardly
…ansparency and bg-filling
…n via line segment clustering easier
…n and decrease slower inwards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83.
We could do so much more, but this already should give a boost in robustness and quality in many scenarios. It also makes identifier and parameter names readable.
I'll probably add some basic DPI relativity later-on, as there are so many parameters here, that were probably fitted to some 300 DPI assumption.