Skip to content

[12.0][MIG] web_search_with_and #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[12.0][MIG] web_search_with_and #1364

wants to merge 5 commits into from

Conversation

LoisRForgeFlow
Copy link
Contributor

Standard migration.

@eficent

Andrius Preimantas and others added 5 commits September 5, 2019 13:22
@LoisRForgeFlow
Squash of 8 commits
f1642b9 
Add README.rst

Too short underline for module title in README.rst

Improving module meta information

Version 1.0

W391 blank line at end of file

Remove module description because README.rst is there

web_search_with_and: Latest OCA conventions
@Creamaster @LoisRForgeFlow
[MIG] Migrate web_search_with_and from 8.0 to 10.0
42cd62f
@OpenCode @LoisRForgeFlow
[MIG] web_search_with_and: Migration to 11.0
8d9bf26
@oca-travis @LoisRForgeFlow
[UPD] Update web_search_with_and.pot
181ad25
@LoisRForgeFlow
[12.0][MIG] web_search_with_and
3f02201
@oca-clabot
Copy link

Hey @lreficent, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

AdriaGForgeFlow
AdriaGForgeFlow approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@AdriaGForgeFlow AdriaGForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test 👍

tarteo
tarteo approved these changes Sep 20, 2019
View reviewed changes
Copy link
Member

@tarteo tarteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-1364-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 20, 2019
@OCA-git-bot
Merge PR #1364 into 12.0
8574c6d 
Signed-off-by pedrobaeza
@pedrobaeza
Copy link
Member

Ouch, there was #1203 before this one. Is that one correct? If so, it should be prioritized. Deleting branch for avoiding merge.

@LoisRForgeFlow
Copy link
Contributor Author

@pedrobaeza did not see that one, sorry. I guess it will work, no changes were required. I will validate the other one and you can merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarteo tarteo tarteo approved these changes

@AdriaGForgeFlow AdriaGForgeFlow AdriaGForgeFlow approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@LoisRForgeFlow @oca-clabot @OCA-git-bot @pedrobaeza @tarteo @AdriaGForgeFlow @Creamaster @OpenCode @oca-travis