[12.0][MIG] - Wildcard in advanced migration to 12.0 #1326

sbejaoui · 2019-07-08T09:41:23Z

In addition to the migration this PR add two new options to web_advanced_search_wildcard:

doesn't start with
doesn't end with

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

Conflicts: web_advanced_search_wildcard/__openerp__.py

[MOD] Update manifest with latest OCA standard Conflicts: web_advanced_search_wildcard/__openerp__.py

[MOD] README [ADD] Screenshot

…h' (OCA#1142) * We keep the historic feature *matches* provided by web_advanced_search_wildcard, but we add *starts with* and *ends with* with are super-easy and intuitive to use and cover the majority of use cases. * FR translation

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

sbejaoui · 2019-07-08T09:43:28Z

@gva-acsone, can you review this please.

gva-acsone

+1 Functional test

pedrobaeza · 2019-07-10T12:55:44Z

Shouldn't this be renamed to accommodate new features? And also as the search feature is now called "Custom filter", this can be confused with existing OCA module that adds a new feature web_advanced_search. I recommend it to call it web_custom_filter_operator_extra or similar.

sbejaoui · 2019-07-10T13:56:42Z

Shouldn't this be renamed to accommodate new features? And also as the search feature is now called "Custom filter", this can be confused with existing OCA module that adds a new feature web_advanced_search. I recommend it to call it web_custom_filter_operator_extra or similar.

+1

web_advanced_search_wildcard/__manifest__.py

web_advanced_search_wildcard/static/src/js/search.js

Tardo

LGTM 👍, code review

daramousk

Works great, some recommendations.

web_advanced_search_wildcard/__manifest__.py

web_advanced_search_wildcard/static/src/js/search.js

OCA-git-bot · 2019-10-19T11:14:59Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

andreampiovesana

go

andreampiovesana · 2020-01-11T21:53:43Z

merge!

legalsylvain · 2020-01-11T23:36:14Z

@sbejaoui : could you take a look on the @daramousk remarks ?

If you have no time, I propose to merge this PR, and wait for another one regarding @daramousk remarks that seems to be cosmectics / non blocking remarks.

thanks.

sbejaoui · 2020-01-17T09:08:58Z

@sbejaoui : could you take a look on the @daramousk remarks ?

Done

dreispt · 2020-04-01T14:58:48Z

/ocabot merge

OCA-git-bot · 2020-04-01T14:59:03Z

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-1326-by-dreispt-bump-no, awaiting test results.

OCA-git-bot · 2020-04-01T15:15:39Z

Congratulations, your PR was merged at fafbbe8. Thanks a lot for contributing to OCA. ❤️

OSguard and others added 21 commits July 8, 2019 10:22

add web_advanced_search_wildcard module

ca5eeaf

rename empty translation file

8106a74

rename module inside translation file

4f799dc

initial german translations (and added pot-file)

9364864

Add OCA as author of OCA addons

12501ee

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

OCA Transbot updated translations from Transifex

42df00d

[FIX] Adept javascript to module name

f6826d7

[PORT][8.0] port web_advanced_search_wildcard

4993cda

Conflicts: web_advanced_search_wildcard/__openerp__.py

[FIX] whitespace

34d84eb

[MOD] Add email address in README file

76cfdc4

[MOD] layout changes to readme file

6ec82a4

[MOD] Update manifest with latest OCA standard Conflicts: web_advanced_search_wildcard/__openerp__.py

[MOD] Manifest

facae83

[MOD] README [ADD] Screenshot

[MIG] web_advanced_search_wildcard: Migration to 10.0

1fc43a3

OCA Transbot updated translations from Transifex

2780eb3

OCA Transbot updated translations from Transifex

931e6a7

[UPD] Update web_advanced_search_wildcard.pot

64d9962

Update translation files

a40fac6

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[UPD] Update web_advanced_search_wildcard.pot

604c157

Update translation files

077d2e9

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[12.0][MIG] - Wildcard in advanced migration to 12.0

74616f7

sbejaoui mentioned this pull request Jul 8, 2019

[Question] - Add new operators to the standard advanced search #1319

Closed

sbejaoui force-pushed the 12.0-mig-web_advanced_search_wildcard branch 2 times, most recently from d9a1b2d to 74616f7 Compare July 9, 2019 13:16

sbejaoui mentioned this pull request Jul 9, 2019

WIP: [web_advanced_search_wildcard module][ADD] - Add doesn't start/end with options #1328

Closed

[ADD] - Add doesn't start/end with options

6fd4995

sbejaoui mentioned this pull request Jul 10, 2019

Migration to version 12.0 #1048

Closed

40 tasks

gva-acsone approved these changes Jul 10, 2019

View reviewed changes

Tardo requested changes Jul 15, 2019

View reviewed changes

web_advanced_search_wildcard/__manifest__.py Show resolved Hide resolved

web_advanced_search_wildcard/static/src/js/search.js Outdated Show resolved Hide resolved

[IMP] - Use super to get default case

ce91dd0

alexey-pelykh approved these changes Jul 22, 2019

View reviewed changes

Tardo approved these changes Jul 22, 2019

View reviewed changes

daramousk reviewed Oct 19, 2019

View reviewed changes

web_advanced_search_wildcard/__manifest__.py Outdated Show resolved Hide resolved

web_advanced_search_wildcard/static/src/js/search.js Outdated Show resolved Hide resolved

web_advanced_search_wildcard/static/src/js/search.js Outdated Show resolved Hide resolved

OCA-git-bot added the approved label Oct 19, 2019

OCA-git-bot added the ready to merge label Oct 19, 2019

andreampiovesana approved these changes Nov 4, 2019

View reviewed changes

Abranes approved these changes Jan 9, 2020

View reviewed changes

[IMP] - Improve code

d70864e

fuentes73 approved these changes Jan 29, 2020

View reviewed changes

ValentinVinagre approved these changes Mar 12, 2020

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Apr 1, 2020

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Apr 1, 2020

OCA-git-bot closed this Apr 1, 2020

OCA-git-bot merged commit 9e4bcfa into OCA:12.0 Apr 1, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12.0][MIG] - Wildcard in advanced migration to 12.0 #1326

[12.0][MIG] - Wildcard in advanced migration to 12.0 #1326

sbejaoui commented Jul 8, 2019 •

edited

Loading

sbejaoui commented Jul 8, 2019

gva-acsone left a comment

pedrobaeza commented Jul 10, 2019

sbejaoui commented Jul 10, 2019

Tardo left a comment

daramousk left a comment

OCA-git-bot commented Oct 19, 2019

andreampiovesana left a comment

andreampiovesana commented Jan 11, 2020

legalsylvain commented Jan 11, 2020

sbejaoui commented Jan 17, 2020

dreispt commented Apr 1, 2020

OCA-git-bot commented Apr 1, 2020

OCA-git-bot commented Apr 1, 2020

[12.0][MIG] - Wildcard in advanced migration to 12.0 #1326

[12.0][MIG] - Wildcard in advanced migration to 12.0 #1326

Conversation

sbejaoui commented Jul 8, 2019 • edited Loading

sbejaoui commented Jul 8, 2019

gva-acsone left a comment

Choose a reason for hiding this comment

pedrobaeza commented Jul 10, 2019

sbejaoui commented Jul 10, 2019

Tardo left a comment

Choose a reason for hiding this comment

daramousk left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Oct 19, 2019

andreampiovesana left a comment

Choose a reason for hiding this comment

andreampiovesana commented Jan 11, 2020

legalsylvain commented Jan 11, 2020

sbejaoui commented Jan 17, 2020

dreispt commented Apr 1, 2020

OCA-git-bot commented Apr 1, 2020

OCA-git-bot commented Apr 1, 2020

sbejaoui commented Jul 8, 2019 •

edited

Loading