Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][Mig] web_searchbar_full_width #1218

Merged
merged 6 commits into from
Mar 18, 2019
Merged

[12.0][Mig] web_searchbar_full_width #1218

merged 6 commits into from
Mar 18, 2019

Conversation

bizzappdev
Copy link

No description provided.

@bizzappdev bizzappdev force-pushed the 12.0-mig-web_searchbar_full_width-krj-bizz branch from 8d7ce88 to ff68419 Compare March 16, 2019 11:01
@pedrobaeza pedrobaeza added this to the 12.0 milestone Mar 17, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 17, 2019
Closed
40 tasks
nikul-serpentcs
nikul-serpentcs suggested changes Mar 18, 2019
View reviewed changes
Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change

@bizzappdev bizzappdev force-pushed the 12.0-mig-web_searchbar_full_width-krj-bizz branch from 77ca720 to 32c8e8f Compare March 18, 2019 06:19
@bizzappdev
Copy link
Author

requested changes are done

sudhir-erpharbor
sudhir-erpharbor reviewed Mar 18, 2019
View reviewed changes
Copy link
Contributor

@sudhir-erpharbor sudhir-erpharbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes

MiquelRForgeFlow
MiquelRForgeFlow approved these changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bizzappdev bizzappdev force-pushed the 12.0-mig-web_searchbar_full_width-krj-bizz branch from 473bdc8 to 9eefaf9 Compare March 18, 2019 13:03
nikul-serpentcs
nikul-serpentcs approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM 👍

sudhir-erpharbor
sudhir-erpharbor approved these changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@sudhir-erpharbor sudhir-erpharbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrobaeza pedrobaeza merged commit 9b2e6d6 into OCA:12.0 Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudhir-erpharbor sudhir-erpharbor sudhir-erpharbor approved these changes

@nikul-serpentcs nikul-serpentcs nikul-serpentcs approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.
10 participants
@bizzappdev @sudhir-erpharbor @nikul-serpentcs @MiquelRForgeFlow @pedrobaeza @OCA-git-bot @hbrunn @bud-e @carlos-domatix @oca-travis