[MIG] web_advanced_search: Migrate to v12 #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
40 tasks
|
@tarteo may I ask your review? |
chienandalu
approved these changes
Feb 21, 2019
|
Merge please. |
|
What about the question:
|
|
If I understand the question fine, the answer is that it depends on the domain selector widget itself, not on the search feature here. You can see some improvements being made for v11 in #1200. |
and replace company icon [FIX] js syntax [FIX] move our patched equals operator to top of list [ADD] support selecting domains on x2x fields [FIX] eval search view's domain [IMP] UI fixes [IMP] reflect recent additions in README.rst [FIX] typos [ADD] translations [FIX] correct js reference [RFR] rebuild our domains in a different way this solves timing problems
I could not find the project on Transifex...
Change fitro by dominio
- Use the new domain widget. - Use modules system.
* Make it good-looking * Update known issues * Fix templates. * Make other operators work again
[MIG] web_advanced_search_x2x: Migrated to 10.0 FIX review Remarks
* Ensure that domain field can be evaluated before creating x2x field * Fixed navigation error after using x2x advanced search
[FIX] StopPropagation when clicking in domain selector.
* Complete migration to v11 * Refactor to use the new v11 decoupled widgets system * Advanced search is now a high-level feature from the filters menu; it simplifies code a lot, and the UX is even better * Split README system * Add fun to ROADMAP * Addon is renamed to web_advanced_search, since it enhaces the searching experience for all kind of fields now
Currently translated at 100,0% (1 of 1 strings) Translation: web-11.0/web-11.0-web_advanced_search Translate-URL: https://translation.odoo-community.org/projects/web-11-0/web-11-0-web_advanced_search/da/
Before this patch, when searching with the "equals to" operator in any x2many field, the searched parameter was always `undefined`. The problem was that the underlying field manager implementation was treating those fields as x2many, while the widget used was the `one2many` one. This patch simply mocks the underlying fake record to make think that any relational field is always a `one2many`. This sets all pieces in place and makes the field manager work as expected, and thus you can search as expected too.
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
If we honor the domain value, the user may not be getting all available
records when selecting from an x2many dropdown, or even worse, if the
domain references another field in the view, the user may be getting
an error when opening the field dropdown, like this:
Error: NameError: name 'company_id' is not defined
http://localhost/web/static/lib/py.js/lib/py.js:370
Rastreo de error:
PY_ensurepy@http://localhost/web/static/lib/py.js/lib/py.js:370:19
py.evaluate@http://localhost/web/static/lib/py.js/lib/py.js:1340:20
py.evaluate@http://localhost/web/static/lib/py.js/lib/py.js:1397:35
py.evaluate@http://localhost/web/static/lib/py.js/lib/py.js:1409:34
py.eval@http://localhost/web/static/lib/py.js/lib/py.js:1453:16
eval_domains/<@http://localhost/web/static/src/js/core/pyeval.js:886:39
_.forEach@http://localhost/web/static/lib/underscore/underscore.js:145:9
_.mixin/</_.prototype[name]@http://localhost/web/static/lib/underscore/underscore.js:1484:29
eval_domains@http://localhost/web/static/src/js/core/pyeval.js:877:16
pyeval@http://localhost/web/static/src/js/core/pyeval.js:988:16
stringToArray@http://localhost/web/static/src/js/core/domain.js:243:16
_getDomain@http://localhost/web/static/src/js/views/basic/basic_model.js:3004:24
_search@http://localhost/web_m2x_options/static/src/js/form.js:139:26
source@http://localhost/web/static/src/js/fields/relational_fields.js:198:17
_search@http://localhost/web/static/lib/jquery.ui/jquery-ui.js:6823:3
$.widget/</proxiedPrototype[prop]</<@http://localhost/web/static/lib/jquery.ui/jquery-ui.js:415:19
search@http://localhost/web/static/lib/jquery.ui/jquery-ui.js:6815:10
$.widget/</proxiedPrototype[prop]</<@http://localhost/web/static/lib/jquery.ui/jquery-ui.js:415:19
$.widget.bridge/$.fn[name]/<@http://localhost/web/static/lib/jquery.ui/jquery-ui.js:508:19
each@http://localhost/web/static/lib/jquery/jquery.js:383:49
each@http://localhost/web/static/lib/jquery/jquery.js:136:24
$.widget.bridge/$.fn[name]@http://localhost/web/static/lib/jquery.ui/jquery-ui.js:494:4
_onInputClick@http://localhost/web/static/src/js/fields/relational_fields.js:565:13
proxy/<@http://localhost/web/static/src/js/core/mixins.js:279:20
dispatch@http://localhost/web/static/lib/jquery/jquery.js:4640:50
add/elemData.handle@http://localhost/web/static/lib/jquery/jquery.js:4309:41
pedrobaeza
force-pushed
the
12.0-web_advanced_search
branch
from
c88c630 to
dbd23a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Routine migration.
@Tecnativa