Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0] [MIG] web_no_bubble #1150

Closed
wants to merge 4 commits into from

Conversation

anandkansagra
Copy link
Member

Issue Reference

@oca-clabot
Copy link

Hey @anandkansagra, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@anandkansagra anandkansagra mentioned this pull request Jan 8, 2019
40 tasks
@anandkansagra anandkansagra force-pushed the 12.0-mig-web_no_bubble branch from 10acb3e to fca3cf2 Compare January 8, 2019 04:25
@pedrobaeza pedrobaeza added this to the 12.0 milestone Jan 8, 2019
@pedrobaeza
Copy link
Member

Is this still needed? I see no bubbles in runbot for v12.

@anandkansagra
Copy link
Member Author

Is this still needed? I see no bubbles in runbot for v12.

@pedrobaeza , I have found a class in ODOO base so this module will work.
https://github.com/odoo/odoo/blob/12.0/addons/web_tour/static/src/scss/tip.scss#L71

@pedrobaeza
Copy link
Member

Class can be there, but if it's not used, this module is unneeded.

@anandkansagra
Copy link
Member Author

Class can be there, but if it's not used, this module is unneeded.

@pedrobaeza , what if somebody use it in custom module?

@pedrobaeza
Copy link
Member

I don't think so, but any way, if not used in Odoo, it doesn't matter. As said, for me this module should disappear.

@nikul-serpentcs
Copy link
Member

I don't think so, but any way, if not used in Odoo, it doesn't matter. As said, for me this module should disappear.

Yes, @pedrobaeza In v12 I think not used bubbles, I checked in runbot but not find it.

@anandkansagra Thanks for contribution

@pedrobaeza
Copy link
Member

I have included the part for migration path to not report this module as absent in v12: OCA/OpenUpgrade@662858b, so closing this. Thanks any way for the effort.

@pedrobaeza pedrobaeza closed this Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants