[12.0] [MIG] web_widget_image_url #1145
Conversation
| placeholder: "/web/static/src/img/placeholder.png", | ||
| supportedFieldTypes: ['char'], | ||
|
|
||
| url(){ |
There was a problem hiding this comment.
This is not the correct syntax, please check the jslint error.
| var AbstractField = require('web.AbstractField'); | ||
| var core = require('web.core'); | ||
| var registry = require('web.field_registry'); | ||
| var QWeb = core.qweb; |
| // License LGPLv3.0 or later (https://www.gnu.org/licenses/lgpl-3.0.en.html). | ||
|
|
||
| odoo.define('web_widget_image_url.FieldImageURL', function (require) { | ||
| "use strict"; |
| <t t-name="FieldImageURL"> | ||
| <span class="oe_form_field oe_form_field_image" t-att-style="widget.attrs.style"> | ||
| <img t-att-src="widget.url()" | ||
| t-att-border="widget.readonly ? 0 : 1" |
There was a problem hiding this comment.
The border attribute is deprecated in html5.
There was a problem hiding this comment.
I don't get it. Could you please describe it more?
There was a problem hiding this comment.
The attribute border is deprecated, please remove it. You can use the style attribute (t-att-style) to add a border to the image instead. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img#Deprecated_attributes
There was a problem hiding this comment.
Thanks for the explanation.
| @@ -0,0 +1,56 @@ | |||
| .. image:: https://www.gnu.org/graphics/lgplv3-147x51.png | |||
There was a problem hiding this comment.
Can you use the new split readme?
anandkansagra
force-pushed
the
12.0-mig-web_widget_image_url
branch
2 times, most recently
from
50f6f2c to
ac5cc00
Compare
|
@tarteo can you update your review please? |
There was a problem hiding this comment.
The syntax is still incorrect (see my comments):
https://travis-ci.org/OCA/web/jobs/477666187#L608
anandkansagra
force-pushed
the
12.0-mig-web_widget_image_url
branch
from
ac5cc00 to
a974387
Compare
anandkansagra
force-pushed
the
12.0-mig-web_widget_image_url
branch
from
a974387 to
03c8d6a
Compare
| $img.on('error', function () { | ||
| $img.attr('src', self.placeholder); | ||
| self.do_warn( | ||
| _t("Image"), _t("Could not display the selected image.")); |
There was a problem hiding this comment.
this can be really annoying if by chance you use the widget on multiple images and you have more than one image missing (tree view for instance).
Out of the scope of this PR but I'd add a TODO in the roadmap.
|
This PR has the |
Issue Reference