Skip to content

[12.0] [MIG] web_tree_image #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 25 commits into from
Closed

[12.0] [MIG] web_tree_image #1100

wants to merge 25 commits into from

Conversation

nikul-serpentcs
Copy link
Member

Display images and icons in tree view

This module defines a tree image widget, to be used with either binary fields or (function) fields of type character. Use widget='image' in your view definition. Optionally, set a width attribute. Default width is 30px.

Stefan Rijnhart and others added 23 commits November 9, 2018 12:48
@nikul-serpentcs
web_tree_widget
1da9afc
@nikul-serpentcs
Handle binary fields. Courtesy of Marcel van der Boom
2fd5c08
@nikul-serpentcs
manifest
d6c8ae5
@nikul-serpentcs
Module description
2c21f45
@nikul-serpentcs
Move module description to README [FIX] rst line endings [IMP] Commen…
18425f5 
…t on arbitrary media subtype
@nikul-serpentcs
Widget name 'image' instead of 'tree_image'
231571d
@nikul-serpentcs
Capitalization consistency
b4fd73b
@gurneyalex @nikul-serpentcs
Add OCA as author of OCA addons
4ff7dfe 
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
@yvaucher @nikul-serpentcs
Add missing default oca icons
edac570
@sbidoul @nikul-serpentcs
prefix versions with 8.0
fe7ec23
@LeartS @nikul-serpentcs
Add support resize option
d900469 
set resize="<width>,<height>" in the field tag definition to
make the server return a resized version of the image.
Useful for saving bandwidth when dealing with large images and to
have uniform image sizes (aspect ratio is mantained by filling
emtpy areas with transparent background)
@LeartS @nikul-serpentcs
Version bump, update README
09a1caa
@pedrobaeza @nikul-serpentcs
Make modules uninstallable
37fd954
@JayVora-SerpentCS @nikul-serpentcs
Migrated web tree image module to v9
6105cbd
@pedrobaeza @nikul-serpentcs
Make modules uninstallable
247d473
@pedrobaeza @nikul-serpentcs
Rename manifest files
774a066
@danieltorres7 @nikul-serpentcs
web_tree_image: Porting to 10.0 (OCA#464)
a81384f
@oca-travis @nikul-serpentcs
Update web_tree_image.pot
7e8336d
@nikul-serpentcs
web_tree_image v11
5a5383e
@nikul-serpentcs
Fixed code
81c9fae
@nikul-serpentcs
Fixed delay time
060c79b
@oca-travis @nikul-serpentcs
Update web_tree_image.pot
9d23ac8
@nikul-serpentcs
[MIG] web_tree_image v12
0404f3c
@nikul-serpentcs
Copy link
Member Author

@JayVora-SerpentCS @pedrobaeza Can you please review it?

@pedrobaeza pedrobaeza added this to the 12.0 milestone Nov 9, 2018
@pedrobaeza
Copy link
Member

Odoo core now supports images in trees. The only missing part now is reading images from URLs, but this module is not needed as is.

@nikul-serpentcs
Copy link
Member Author

@pedrobaeza In base image size very large.
Like This.
odoo 1

that's why this module here useful, In module set image size with tooltip.

@pedrobaeza
Copy link
Member

@nikul-serpentcs but that's something you can limit size putting options and attributes AFAIK

@nikul-serpentcs
Copy link
Member Author

nikul-serpentcs commented Nov 9, 2018 •
edited
Loading

@nikul-serpentcs but that's something you can limit size putting options and attributes AFAIK

Yes, But Regarding v11 #1006 (comment) and #1006 (comment)

we used size with tooltip

CC @tarteo

@oca-clabot
Copy link

Hey @nikul-serpentcs, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@nikul-serpentcs nikul-serpentcs mentioned this pull request Dec 18, 2018
Merged
@emagdalenaC2i emagdalenaC2i mentioned this pull request Dec 29, 2018
Closed
40 tasks
@nikul-serpentcs
Copy link
Member Author

@pedrobaeza @tarteo @oca-clabot All comment changes are Done, Can you please move forward.

@nikul-serpentcs
Copy link
Member Author

@pedrobaeza @tarteo @oca-clabot All comment changes are Done, Can you please move forward.

Ping

@TimLai125
Copy link

Hi @pedrobaeza @tarteo @nikul-serpentcs May I know if there is anything pending with this PR?

tarteo
tarteo approved these changes Apr 30, 2019
View reviewed changes
Copy link
Member

@tarteo tarteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TimLai125 The README is still bad but the functionality is OK.

TimLai125
TimLai125 reviewed Apr 30, 2019
View reviewed changes
Copy link

@TimLai125 TimLai125 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a picky comment, the tooltip image is not showed for the first hover, e.g. https://drive.google.com/file/d/1A3Y-Ag4Z508uXTKmocBO9Cz6-yCWOroo/view

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@tarteo
Copy link
Member

tarteo commented Apr 30, 2019 •
edited
Loading

Might be a picky comment, the tooltip image is not showed for the first hover, e.g. https://drive.google.com/file/d/1A3Y-Ag4Z508uXTKmocBO9Cz6-yCWOroo/view

This seems the case, this needs to be fixed before merge unless this was also the case in 11.0.

Tardo
Tardo approved these changes Jun 25, 2019
View reviewed changes
Copy link
Member

@Tardo Tardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Rebased to 12.0-ocabot-merge-pr-1100-by-pedrobaeza-bump-no, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ede66ca. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 12.0.

OCA-git-bot added a commit that referenced this pull request Jun 25, 2019
@OCA-git-bot
Merge PR #1100 into 12.0
ede66ca 
Signed-off-by pedrobaeza
@nikul-serpentcs nikul-serpentcs deleted the 12-mig-web_tree_image branch June 26, 2019 04:33
@victoralmau victoralmau mentioned this pull request Mar 10, 2022
Merged
@legalsylvain
Copy link
Contributor

Hi @nikul-serpentcs

just a message to thank you for this excellent module, which covers exactly a recent need in my company.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JayVora-SerpentCS JayVora-SerpentCS JayVora-SerpentCS left review comments

@pedrobaeza pedrobaeza pedrobaeza left review comments

@sudhir-erpharbor sudhir-erpharbor sudhir-erpharbor left review comments

@TimLai125 TimLai125 TimLai125 left review comments

@alexey-pelykh alexey-pelykh alexey-pelykh approved these changes

@Tardo Tardo Tardo approved these changes

@tarteo tarteo tarteo approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.