12.0 mig web m2x options #1086

gustitammam · 2018-10-19T01:07:58Z

No description provided.

oca-clabot · 2018-10-19T01:08:00Z

Hey @gustitammam, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

@gustitammam (login unknown in OCA database)

Appreciation of efforts,
OCA CLAbot

pedrobaeza · 2019-01-08T08:42:09Z

Please add #1118 to this PR

nikul-serpentcs

Improve Code

nikul-serpentcs · 2019-01-08T11:02:27Z

web_m2x_options/__manifest__.py

@@ -0,0 +1,23 @@
+


@gustitammam IMO Add copyright

@gustitammam IMO Add copyright

@nikul-serpentcs here: 85a462d

web_m2x_options/__manifest__.py

gustitammam · 2019-01-09T00:18:36Z

Please add #1118 to this PR

@pedrobaeza This is it: 12c88b0

pedrobaeza · 2019-01-09T01:14:12Z

@gustitammam please don't do merge operations over the branch, as this scrambles the commit history and provoke conflicts for next versions. Please rebase now over 12.0 branch for fixing commit history.

gustitammam · 2019-01-09T09:01:06Z

@gustitammam please don't do merge operations over the branch, as this scrambles the commit history and provoke conflicts for next versions. Please rebase now over 12.0 branch for fixing commit history.

I just rebase it, @pedrobaeza please review, is this correct?

pedrobaeza · 2019-01-16T17:31:09Z

There's a new change in 11.0: ddbbe81

pedrobaeza · 2019-01-16T17:31:34Z

@gustitammam the rest seems OK. Thanks for the efforts.

gustitammam · 2019-01-17T22:33:23Z

There's a new change in 11.0: ddbbe81

Here is it: 877bc32

pedrobaeza · 2019-01-17T22:35:56Z

@gustitammam how are you handling additions? there are duplicated commits now. For example, I see 3 commits for "[MIG] web_m2x_options: Migration to 11.0", which should be only one.

gustitammam · 2019-01-17T22:40:03Z

@gustitammam how are you handling additions? there are duplicated commits now. For example, I see 3 commits for "[MIG] web_m2x_options: Migration to 11.0", which should be only one.

I'm doing this: git format-patch --keep-subject --stdout origin/12.0..origin/11.0 -- $MODULE | git am -3 --keep
Actually I also not sure about this way. How should I handle the change ?

pedrobaeza · 2019-01-17T22:43:31Z

But each time you include a commit? That's why there are duplicated commits.

You should only cherry-pick the needed commit. Please clean the PR removing the duplicated commits and being sure no valid code is removed.

gustitammam · 2019-01-17T23:30:27Z

But each time you include a commit? That's why there are duplicated commits.

You should only cherry-pick the needed commit. Please clean the PR removing the duplicated commits and being sure no valid code is removed.

Please check, I was removing the duplicated commits with this steps:

I reset to my first commit: https://github.com/Linksoft-ID/web/commit/5e8c3559c66855f989423575df0ac881b5b037ba
Then I cherry-pick commit from this PR: [FIX] open option on many2many_tags #1118
Then I cherry-pick this commit: ddbbe81

pedrobaeza · 2019-01-18T00:51:06Z

Great, thanks. Now it looks correct.

@ernestotejeda please review this one.

ernestotejeda

if the option 'open' is set in true, when clicking on an element A, the associated resource will be opened in a dialog, but the color palette in the background is also shown. After closing the dialog, each time you click A, othe color palette is shown and not the dialog, unless you select another color for element A.

ernestotejeda

The no_color_picker option doesn't seem to work

ernestotejeda

Generate README.rst file, please

bealdav · 2019-02-11T18:53:41Z

No news here ? Thanks

jcdrubay · 2019-02-12T06:52:05Z

I tested for a few days and it worked well. nice :)

jcdrubay

I tested for few days and it worked nicely.

pedrobaeza · 2019-02-13T11:25:58Z

@gustitammam can you check pending comment?

gustitammam · 2019-02-18T01:15:22Z

if the option 'open' is set in true, when clicking on an element A, the associated resource will be opened in a dialog, but the color palette in the background is also shown. After closing the dialog, each time you click A, othe color palette is shown and not the dialog, unless you select another color for element A.

Honestly I never know about web_m2x_options.open option is exist, I used to use this options: web_m2x_options.create, web_m2x_options.create_edit, web_m2x_options.m2o_dialog.

@ernestotejeda I'm trying to reproduce your step, I set web_m2x_options.open to True but nothing happen when I click on many2many_tags. How can a popup show up in yours ?

@pedrobaeza Maybe I need some helps about this issue. It's quite difficult for me.

pedrobaeza · 2019-02-18T08:46:12Z

@ernestotejeda please assist in this to @gustitammam

rven · 2019-02-18T14:16:56Z

@gustitammam could you please do a git rebase origin/12.0 on this PR?

ernestotejeda · 2019-02-19T05:54:17Z

So, here are the steps

bealdav · 2019-02-19T08:30:11Z

Mergeable ?

gustitammam · 2019-02-19T11:56:14Z

@ernestotejeda Thank you for the clue, open and no_color_picker is fixed now in 396e4f5, also I generate the README.rst in a6e51e3

@rven done, it's rebased.

rven · 2019-02-19T14:12:08Z

@gustitammam I think the rebase is not done correctly
first you have to fetch the changes of the origin and then you have to rebase these remote changes into your branch.
I'm getting conflicts on the latest 12.0 branch when applying your PR.

Merge pull request #1187 from Tardo/pr_imp_sticky

git remote -v
origin https://github.com/OCA/web.git (fetch)
origin https://github.com/OCA/web.git (push)

git fetch origin # Updates origin/12.0
git rebase origin/12.0 # Rebases current branch onto origin/12.0

then force push these changes.

Before you rebase you also have to fetch the remote branch for changes.

- Add static/description/index.html fix: use include instead of extend in js function inheritance. fix: not overwriting the existing object references with the result of the include fix: update name according to new module name. fix: error when displaying many2many field without options defined.

[ADD] support 'no_open_edit' on many2one [FIX] typos

…and make the module installable [MIG] adapt form.js to the new API. [FIX] Fix bug mentioned in pull #262. [MIG] Make the module installable.

…th `options={'open': True}` it always open the first element with this fix it will open the right one

* [FIX][web_m2x_options] Fix Qweb templates. They were trying to replace non-existing elements, and this was being logged to console: Can't find "a.oe_m2o_cm_button" when extending template FieldMany2One Can't find "span.badge" when extending template FieldMany2ManyTag * Raise version correctly. * [FIX] Make many2many_tags tag deletion work again * Correct replacement of event Instead of overwriting all events from upstream widget, better just overwrite the one you need and inherit the rest.

* fix unecessary calls Do check_access_rights and disable_quick_create calls only once per field.

…ser does not have creation permission.

@http

`web_m2x_options` is supposed to render fields in the context of a form or tree view, where domains can safely be applied because there's a main record that includes a context. However, when installing along with `web_advanced_search_x2x`, they produce an incompatibility when a x2x field's domain is defined and depends on the current record's context, because a search view has no notion of a *current record*. The fix is simple: try to do as usual, and if it fails, try without the field's domain. Without this patch, an exception like this would be raised, i.e. when both addons are installed and you are trying to search project tasks by stage: ``` Error: NameError: name 'project_id' is not defined http://localhost/web/static/lib/py.js/lib/py.js:370# Traceback:# Changes to be committed: PY_ensurepy@http://localhost/web/static/lib/py.js/lib/py.js:370:19# modified: static/src/js/form.js py.evaluate@http://localhost/web/static/lib/py.js/lib/py.js:1340:20# py.evaluate@http://localhost/web/static/lib/py.js/lib/py.js:1397:35 py.evaluate@http://localhost/web/static/lib/py.js/lib/py.js:1409:34 py.eval@http://localhost/web/static/lib/py.js/lib/py.js:1453:16 eval_domains/<@http://localhost/web/static/src/js/framework/pyeval.js:869:39 _.forEach@http://localhost/web/static/lib/underscore/underscore.js:145:9 _.mixin/</_.prototype[name]@http://localhost/web/static/lib/underscore/underscore.js:1484:29 eval_domains@http://localhost/web/static/src/js/framework/pyeval.js:860:5 eval_domains/<@http://localhost/web/static/src/js/framework/pyeval.js:873:39 _.forEach@http://localhost/web/static/lib/underscore/underscore.js:145:9 _.mixin/</_.prototype[name]@http://localhost/web/static/lib/underscore/underscore.js:1484:29 eval_domains@http://localhost/web/static/src/js/framework/pyeval.js:860:5 eval_domains/<@http://localhost/web/static/src/js/framework/pyeval.js:873:39 _.forEach@http://localhost/web/static/lib/underscore/underscore.js:145:9 _.mixin/</_.prototype[name]@http://localhost/web/static/lib/underscore/underscore.js:1484:29 eval_domains@http://localhost/web/static/src/js/framework/pyeval.js:860:5 pyeval@http://localhost/web/static/src/js/framework/pyeval.js:977:16 eval_arg@http://localhost/web/static/src/js/framework/pyeval.js:988:16 ensure_evaluated@http://localhost/web/static/src/js/framework/pyeval.js:1011:21 call@http://localhost/web/static/src/js/framework/data_model.js:56:9 name_search@http://localhost/web/static/src/js/framework/data.js:537:16 get_search_result@http://localhost/web_m2x_options/static/src/js/form.js:130:50 OdooClass.extend/Class.include/</prototype[name]</<@http://localhost/web/static/src/js/framework/class.js:122:35 source@http://localhost/web/static/src/js/views/form_relational_widgets.js:271:17 _search@http://localhost/web/static/lib/jquery.ui/jquery-ui.js:6823:3 $.widget/</proxiedPrototype[prop]</<@http://localhost/web/static/lib/jquery.ui/jquery-ui.js:415:19 search@http://localhost/web/static/lib/jquery.ui/jquery-ui.js:6815:10 $.widget/</proxiedPrototype[prop]</<@http://localhost/web/static/lib/jquery.ui/jquery-ui.js:415:19 $.widget.bridge/$.fn[name]/<@http://localhost/web/static/lib/jquery.ui/jquery-ui.js:508:19 each@http://localhost/web/static/lib/jquery/jquery.js:383:49 each@http://localhost/web/static/lib/jquery/jquery.js:136:24 $.widget.bridge/$.fn[name]@http://localhost/web/static/lib/jquery.ui/jquery-ui.js:494:4 render_editable/<@http://localhost/web/static/src/js/views/form_relational_widgets.js:189:21 dispatch@http://localhost/web/static/lib/jquery/jquery.js:4640:50 add/elemData.handle@http://localhost/web/static/lib/jquery/jquery.js:4309:41 ```

gustitammam · 2019-02-19T14:35:03Z

@rven please try again.

ernestotejeda

It's working great

web_m2x_options: Fix usage for non-admins web_m2x_options: Reduce rpc calls web_m2x_options: Update manifest and readme

Currently translated at 91.7% (11 of 12 strings) Translation: web-11.0/web-11.0-web_m2x_options Translate-URL: https://translation.odoo-community.org/projects/web-11-0/web-11-0-web_m2x_options/pt_BR/

@http

The method `_onOpenColorPicker` is defined on `FormFieldMany2ManyTags`, not in `FieldMany2ManyTags`, so it can only be called on its descendants. Otherwise, clicking on a `many2many_tags` tag when found in a tree view produces an error such as: TypeError: self._onOpenColorPicker is not a function http://localhost/web_m2x_options/static/src/js/form.js:354 Rastreo de error: _onOpenBadge@http://localhost/web_m2x_options/static/src/js/form.js:354:17 proxy/<@http://localhost/web/static/src/js/core/mixins.js:279:20 dispatch@http://localhost/web/static/lib/jquery/jquery.js:4640:50 add/elemData.handle@http://localhost/web/static/lib/jquery/jquery.js:4309:41 (cherry picked from commit ddbbe81)

pedrobaeza · 2019-02-21T00:24:41Z

Thanks for the contribution

pedrobaeza added this to the 12.0 milestone Oct 19, 2018

pedrobaeza added the needs review label Oct 19, 2018

OCA-git-bot mentioned this pull request Oct 19, 2018

Migration to version 12.0 #1048

Closed

40 tasks

nikul-serpentcs suggested changes Jan 8, 2019

View reviewed changes

ernestotejeda reviewed Jan 23, 2019

View reviewed changes

jcdrubay approved these changes Feb 12, 2019

View reviewed changes

Nicolas JEUDY and others added 17 commits February 19, 2019 21:28

move all addons to __unported__, set all addons as not installable

c0efc81

fix: obscur wrong path on last commit. recreate portage from scratch.

8b87230

support 'open' on many2many_tags

9dbf759

[ADD] support 'no_open_edit' on many2one [FIX] typos

web_m2x_options check Many2one and Many2many options

417fdcd

OCA Transbot updated translations from Transifex

51e24cb

Limit name_search to 160 like Odoo core does

3e9f556

Migration of module web_m2x_options. Adapt JS file to the new JS API …

7316fdf

…and make the module installable [MIG] adapt form.js to the new API. [FIX] Fix bug mentioned in pull #262. [MIG] Make the module installable.

Makes the module compatible with Odoo community

33e76f3

web_m2x_options: s/ev.handleObj.selector/currentTarget * many2many wi…

3098c1d

…th `options={'open': True}` it always open the first element with this fix it will open the right one

OCA Transbot updated translations from Transifex

38236f6

[MIG] web_m2x_options: migrated to 10.0

9cdde90

[IMP] web_m2x_options: Perf issue #615

ba0a6c0

* fix unecessary calls Do check_access_rights and disable_quick_create calls only once per field.

web_m2x_options: Hide the create/create and edit... button when the u…

e91384d

…ser does not have creation permission.

[10.0][ADD] option to deactivate color picker on many2many_tags (#713)

078dcb9

ernestotejeda approved these changes Feb 20, 2019

View reviewed changes

ernestotejeda and others added 6 commits February 21, 2019 01:08

[MIG] web_m2x_options: Migration to 11.0

60b2779

web_m2x_options: Fix usage for non-admins web_m2x_options: Reduce rpc calls web_m2x_options: Update manifest and readme

[UPD] Update web_m2x_options.pot

912a312

Translated using Weblate (Portuguese (Brazil))

5972186

Currently translated at 91.7% (11 of 12 strings) Translation: web-11.0/web-11.0-web_m2x_options Translate-URL: https://translation.odoo-community.org/projects/web-11-0/web-11-0-web_m2x_options/pt_BR/

[FIX] open option on many2many_tags

b49854f

[MIG] web_m2x_options: Migration to 12.0

f17564d

pedrobaeza merged commit 2296c72 into OCA:12.0 Feb 21, 2019

gustitammam deleted the 12.0-mig-web_m2x_options branch February 21, 2019 01:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

12.0 mig web m2x options #1086

12.0 mig web m2x options #1086

gustitammam commented Oct 19, 2018

oca-clabot commented Oct 19, 2018

pedrobaeza commented Jan 8, 2019

nikul-serpentcs left a comment

nikul-serpentcs Jan 8, 2019

gustitammam Jan 9, 2019

gustitammam commented Jan 9, 2019

pedrobaeza commented Jan 9, 2019

gustitammam commented Jan 9, 2019

pedrobaeza commented Jan 16, 2019

pedrobaeza commented Jan 16, 2019

gustitammam commented Jan 17, 2019

pedrobaeza commented Jan 17, 2019

gustitammam commented Jan 17, 2019

pedrobaeza commented Jan 17, 2019

gustitammam commented Jan 17, 2019

pedrobaeza commented Jan 18, 2019

ernestotejeda left a comment

ernestotejeda left a comment

ernestotejeda left a comment

bealdav commented Feb 11, 2019

jcdrubay commented Feb 12, 2019

jcdrubay left a comment

pedrobaeza commented Feb 13, 2019

gustitammam commented Feb 18, 2019

pedrobaeza commented Feb 18, 2019

rven commented Feb 18, 2019

ernestotejeda commented Feb 19, 2019

bealdav commented Feb 19, 2019

gustitammam commented Feb 19, 2019

rven commented Feb 19, 2019

gustitammam commented Feb 19, 2019

ernestotejeda left a comment

pedrobaeza commented Feb 21, 2019

12.0 mig web m2x options #1086

12.0 mig web m2x options #1086

Conversation

gustitammam commented Oct 19, 2018

oca-clabot commented Oct 19, 2018

pedrobaeza commented Jan 8, 2019

nikul-serpentcs left a comment

Choose a reason for hiding this comment

nikul-serpentcs Jan 8, 2019

Choose a reason for hiding this comment

gustitammam Jan 9, 2019

Choose a reason for hiding this comment

gustitammam commented Jan 9, 2019

pedrobaeza commented Jan 9, 2019

gustitammam commented Jan 9, 2019

pedrobaeza commented Jan 16, 2019

pedrobaeza commented Jan 16, 2019

gustitammam commented Jan 17, 2019

pedrobaeza commented Jan 17, 2019

gustitammam commented Jan 17, 2019

pedrobaeza commented Jan 17, 2019

gustitammam commented Jan 17, 2019

pedrobaeza commented Jan 18, 2019

ernestotejeda left a comment

Choose a reason for hiding this comment

ernestotejeda left a comment

Choose a reason for hiding this comment

ernestotejeda left a comment

Choose a reason for hiding this comment

bealdav commented Feb 11, 2019

jcdrubay commented Feb 12, 2019

jcdrubay left a comment

Choose a reason for hiding this comment

pedrobaeza commented Feb 13, 2019

gustitammam commented Feb 18, 2019

pedrobaeza commented Feb 18, 2019

rven commented Feb 18, 2019

ernestotejeda commented Feb 19, 2019

bealdav commented Feb 19, 2019

gustitammam commented Feb 19, 2019

rven commented Feb 19, 2019

gustitammam commented Feb 19, 2019

ernestotejeda left a comment

Choose a reason for hiding this comment

pedrobaeza commented Feb 21, 2019