[12.0][MIG] web_listview_range_select #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarteo
changed the title
SimoRubi
approved these changes
Oct 2, 2018
web_listview_range_select/README.rst
Outdated
| Configuration | ||
| ============= | ||
|
|
||
| No configuration is needed. |
There was a problem hiding this comment.
might as well remove this chapter
pedrobaeza
approved these changes
Oct 11, 2018
|
@pedrobaeza Yes, me too. I'll put them on the roadmap.
|
[FIX] Firefox shift click [REM] Removed unnecessary configure section [ADD] Roadmap with new features
tarteo
force-pushed
the
12.0-web-range-select
branch
from
3c2266a to
6ec6e6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to use window.getSelection().removeAllRanges(); to make this module work for 12.0. In 12.0 they use 'fake' checkboxes (which are actual a div). That causes shift clicking to select the content. If you have a better solution please, say :).
I updated the README using the new seperated method.