-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG][16.0] hr_timesheet_sheet #591
Conversation
* [10.0] hr_timesheet_sheet * [11.0][MIG] hr_timesheet_sheet * [REMOVE] hr_timesheet.sheet.account * [REMOVE] 'new' state * [ADD] Tests * [UPD] Adapt to multicompany * [ADD] Add more tests (include multicompany tests) * [FIX] project_task_stage_allow_timesheet: show error message only if task * [ADD] Migration scripts to v11
Currently translated at 98.9% (88 of 89 strings) Translation: hr-timesheet-11.0/hr-timesheet-11.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/hr-timesheet-11-0/hr-timesheet-11-0-hr_timesheet_sheet/ja/
Currently translated at 100,0% (89 of 89 strings) Translation: hr-timesheet-11.0/hr-timesheet-11.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/hr-timesheet-11-0/hr-timesheet-11-0-hr_timesheet_sheet/pt_BR/
…ay into this module, which adds a configuration to select the week start day.
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
If you run tests on Sunday, test_4 was not prepared for it, as next day is Monday, which belongs to other week, and thus not included in same timesheet. With this, we cover that case, decreasing one day instead of adding it.
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Currently translated at 81.9% (150 of 183 strings) Translation: timesheet-15.0/timesheet-15.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-15-0/timesheet-15-0-hr_timesheet_sheet/it/
Currently translated at 100.0% (183 of 183 strings) Translation: timesheet-15.0/timesheet-15.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-15-0/timesheet-15-0-hr_timesheet_sheet/it/
Currently translated at 100.0% (183 of 183 strings) Translation: timesheet-15.0/timesheet-15.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-15-0/timesheet-15-0-hr_timesheet_sheet/it/
Currently translated at 100.0% (183 of 183 strings) Translation: timesheet-15.0/timesheet-15.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-15-0/timesheet-15-0-hr_timesheet_sheet/it/
Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: timesheet-15.0/timesheet-15.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-15-0/timesheet-15-0-hr_timesheet_sheet/
Currently translated at 100.0% (183 of 183 strings) Translation: timesheet-15.0/timesheet-15.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-15-0/timesheet-15-0-hr_timesheet_sheet/it/
Currently translated at 100.0% (183 of 183 strings) Translation: timesheet-15.0/timesheet-15.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-15-0/timesheet-15-0-hr_timesheet_sheet/it/
Currently translated at 21.8% (40 of 183 strings) Translation: timesheet-15.0/timesheet-15.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-15-0/timesheet-15-0-hr_timesheet_sheet/sl/
Currently translated at 100.0% (183 of 183 strings) Translation: timesheet-15.0/timesheet-15.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-15-0/timesheet-15-0-hr_timesheet_sheet/it/
Currently translated at 100.0% (183 of 183 strings) Translation: timesheet-15.0/timesheet-15.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-15-0/timesheet-15-0-hr_timesheet_sheet/it/
Currently translated at 22.4% (41 of 183 strings) Translation: timesheet-15.0/timesheet-15.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-15-0/timesheet-15-0-hr_timesheet_sheet/sl/
Currently translated at 100.0% (183 of 183 strings) Translation: timesheet-15.0/timesheet-15.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-15-0/timesheet-15-0-hr_timesheet_sheet/it/
Currently translated at 100.0% (183 of 183 strings) Translation: timesheet-15.0/timesheet-15.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-15-0/timesheet-15-0-hr_timesheet_sheet/it/
Currently translated at 100.0% (183 of 183 strings) Translation: timesheet-15.0/timesheet-15.0-hr_timesheet_sheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-15-0/timesheet-15-0-hr_timesheet_sheet/it/
<field | ||
name="groups_id" | ||
eval="[(4,ref('hr_timesheet.group_hr_timesheet_user'))]" | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we need to remove this and add groups in each part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something needed in v16. Please check the point "Any view with groups_id..." in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Have you considered this comment: #580 (comment) |
Why opening this PR? There's already a migration in #580 |
@astirpe |
The migration needed a few fixes to tests and views, each in separate commits.
Furthermore, create have been made to wok in batch and the deprecated dynamic onchange has been upgraded to a binary domain field.