[IMP] Code review

OCA · Mar 21, 2019 · 7997109 · 7997109
1 parent 044654d
commit 7997109
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/hr_timesheet_sheet/models/hr_timesheet_sheet.py b/hr_timesheet_sheet/models/hr_timesheet_sheet.py
@@ -58,11 +58,10 @@ def _default_date_end(self):
 
     def _default_employee(self):
         company = self.env['res.company']._company_default_get()
-        employee = self.env['hr.employee'].search([
+        return self.env['hr.employee'].search([
             ('user_id', '=', self.env.uid),
             ('company_id', '=', company.id),
         ], limit=1)
-        return employee
 
     name = fields.Char(
         string="Note",
@@ -400,11 +399,8 @@ def action_timesheet_confirm(self):
             if sheet.employee_id.parent_id.user_id:
                 self.message_subscribe_users(
                     user_ids=[sheet.employee_id.parent_id.user_id.id])
-        self.write({
-            'state': 'confirm',
-            'add_line_project_id': False,
-            'add_line_task_id': False,
-        })
+        self.reset_add_line()
+        self.write({'state': 'confirm'})
 
     @api.multi
     def action_timesheet_done(self):
@@ -424,8 +420,13 @@ def button_add_line(self):
         for rec in self:
             if rec.state in ['new', 'draft']:
                 rec.add_line()
-                rec.add_line_task_id = False
-                rec.add_line_project_id = False
+                rec.reset_add_line()
+
+    def reset_add_line(self):
+        self.write({
+            'add_line_project_id': False,
+            'add_line_task_id': False,
+        })
 
     def _get_date_name(self, date):
         name = babel.dates.format_skeleton(