Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][IMP] survey_skip_start: simpler implementation #108

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

chienandalu
Copy link
Member

Simplifies the implementation and bring compatibility with any survey layout.

cc @Tecnativa TT47278

please review @pedrobaeza @victoralmau

@pedrobaeza pedrobaeza added this to the 15.0 milestone Jan 19, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is hacking current process, you should document it properly for future references, and make sure the test covers the flow in case this fails.

survey_skip_start/models/survey_survey.py Show resolved Hide resolved
Simplifies the implementation and bring compatibility with any survey
layout.

TT47278
@chienandalu chienandalu force-pushed the 15.0-imp-survey_skip_start branch from 2a663c2 to 3dacf26 Compare January 19, 2024 15:45
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-108-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7dc7f72 into OCA:15.0 Jan 19, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9eedade. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-imp-survey_skip_start branch January 19, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants