[ADD][12.0] module mail_send_bcc to receive all mail sent by Odoo in bcc

[legalsylvain]

Supersed OCA/server-tools#1722. (bad repository)

Migrate a simple module from GRAP V8 incubator repository.

This module overload the send of email in odoo. For each mail sent, odoo will add, in the "Bcc" field, the email present in the "From" field.

Consequently, when the users are sending mail via Odoo to a partner (customer, supplier), they will receive a copy of the email.
Also, if the partner answer to the email, and your mail provider is handling correctly thread (as Gmail does), you'll have the whole history of the mails in your mailbox.

CC : @quentinDupont, @etobella, @pedrobaeza

#GRAPOCA

[etobella]

LGTM 👍 Just a small nitpicking (non blocking)

[etobella]

OCA/social

[JordiBForgeFlow]

@legalsylvain what do you think about this module supporting cc as well? Do you think that would be feasible?

[legalsylvain]

@legalsylvain what do you think about this module supporting cc as well? Do you think that would be feasible?

Which module ? This one : https://github.com/OCA/social/tree/8.0/base_mail_bcc

If yes, that is different need. base_mail_bcc send allways to the same adresses. My module send to the sender. (from field)
base_mail_bcc is useless in my situation. I have a DB with multi company enabled (50 companies) and adress should be dynamic.

So propose to keep both modules in the OCA. (even if in reality, the module base_mail_bcc is only available for V 8.)

[JordiBForgeFlow]

@legalsylvain I mean to add the ability to add people in CC and in BCC. Seems that this module only supports BCC. Right?

[legalsylvain]

@jbeficent : OK. I get it.
yes it is feasable, adding configuration in res.config.settings.
But it is not in the scope of this PR.

I renamed the module to mail_send_copy and add a section in the Roadmap. Feel free to implement this feature.
Otherwise, is the PR OK ?

regards.

[quentinDupont]

Works fine for user ✔️

Travis fail for a good reason : a mail_tracking test is failing with this module

This is this test.The test failed because we can send the email even if there is no partner email.
Indeed, with this module, we automatically add the BCC field, and so the email is sent even if there is not partner email.

Maybe we can check if there is a partner email before adding BCC ?

[legalsylvain]

Travis fail for a good reason : a mail_tracking test is failing with this module

This is this test.The test failed because we can send the email even if there is no partner email.
Indeed, with this module, we automatically add the BCC field, and so the email is sent even if there is not partner email.

Maybe we can check if there is a partner email before adding BCC ?

Thanks a lot @quentinDupont for your analysis. I'll take a look.

[legalsylvain]

Hi.
There is an error for runbot, but the error is also present on 12.0 Branch.

Ref : https://runbot.odoo-community.org/runbot/repo/https-github-com-oca-social-205

that's weird, because the runbot seems to have failed in the previous merged PR from @pedrobaeza available here : #602

but the bot seems to have ignored and merged.
I thought that using bot was preventing having main branches red.

Any idea ? @sbidoul maybe ?

thanks !

[sbidoul]

I thought that using bot was preventing having main branches red.

ocabot merge ignores runbot errors. Why is runbot red and travis green?

[legalsylvain]

Hi @sbidoul

ocabot merge ignores runbot errors.

thanks for your answer. I didn't know.

Why is runbot red and travis green?

No idea. there are some errors here : https://runbot3.odoo-community.org/runbot/static/build/3437583-462-fc2fc0/logs/job_10_test_base.txt but seems fully unrelated to my PR.

AttributeError: module 'subprocess' has no attribute '_optim_args_from_interpreter_flags'

...

[91mnpm WARN saveError ENOENT: no such file or directory, open '/home/odoo/build/OCA/social/package.json'

...

Building wheel for pyldap (setup.py): finished with status 'error'
[91m  ERROR: Command errored out with exit status 1:
   command: /.repo_requirements/virtualenv/python3.5/bin/python -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-kd21hkwp/pyldap/setup.py'"'"'; __file__='"'"'/tmp/pip-install-kd21hkwp/pyldap/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' bdist_wheel -d /tmp/pip-wheel-sgoo2or7
       cwd: /tmp/pip-install-kd21hkwp/pyldap/

...

  Building wheel for suds-jurko (setup.py): finished with status 'error'
[91m  ERROR: Command errored out with exit status 1:
   command: /.repo_requirements/virtualenv/python3.5/bin/python -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-kd21hkwp/suds-jurko/setup.py'"'"'; __file__='"'"'/tmp/pip-install-kd21hkwp/suds-jurko/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' bdist_wheel -d /tmp/pip-wheel-7dqfofcs
       cwd: /tmp/pip-install-kd21hkwp/suds-jurko/

[sbidoul]

Looks like an issue with the latest setuptools. pypa/setuptools#2357 seems related.

[sbidoul]

We can try this: OCA/maintainer-quality-tools#675

[legalsylvain]

now green. Thanks @sbidoul !

[legalsylvain]

Hi @OCA/social-maintainers : this PR could be merged IMO.

[sebastienbeau]

/ocabot merge nobump
Thanks for your work @legalsylvain

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-462-by-sebastienbeau-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at d7700e1. Thanks a lot for contributing to OCA. ❤️

[rafaelbn]

@JordiBForgeFlow @legalsylvain FYI: https://github.com/OCA/social/tree/15.0/mail_composer_cc_bcc

[legalsylvain]

Thanks ! I didn't know ! The module looks way more complex than the current one. (with full overwrite of odoo functions)

but looks promising and is more complete !