-
-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] mail_notification_custom_subject: Migration to 18.0 #1577
[18.0][MIG] mail_notification_custom_subject: Migration to 18.0 #1577
Conversation
|
…l notifications This module allows you to specify templates to override the subject on the notification emails sent by Odoo. TT27191 Co-authored-by: Pedro M. Baeza <[email protected]>
…ad_template_does_not_break test
[UPD] README.rst
[IMP] update dotfiles [ci skip]
TT36470 [UPD] Update mail_notification_custom_subject.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-15.0/social-15.0-mail_notification_custom_subject Translate-URL: https://translation.odoo-community.org/projects/social-15-0/social-15-0-mail_notification_custom_subject/
… send messages After installing the module, any user was required to have admin rights to be able to search across models. This fix does just that search with sudo and returns back to non-sudo mode immediately after. This way, we don't need to increase permissions for everybody. Tests now run unprivileged, to assert this problem never happens again. @moduon MT-1644 MT-1645
[UPD] README.rst mail_notification_custom_subject 15.0.1.0.1
…n selecting subtype_id [UPD] README.rst mail_notification_custom_subject 15.0.1.0.2
…ert syntaxis of jinja2 to jinja3 [UPD] README.rst
[UPD] Update mail_notification_custom_subject.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-17.0/social-17.0-mail_notification_custom_subject Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_notification_custom_subject/
Translated using Weblate (Italian) Currently translated at 100.0% (20 of 20 strings) Translation: social-17.0/social-17.0-mail_notification_custom_subject Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_notification_custom_subject/it/
…ld translatable TT52259 [BOT] post-merge updates
… it is already set If we write something from the mail thread (without subject) it is only when it should replace the subject. TT52259
…ception to know what has happened TT52259
Example use Case: Our company is called: MY_COMPANY_NAME but is known as MCN, we want to replace in some places the subject line so that it is sent with MCN TT52259 [UPD] Update mail_notification_custom_subject.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-17.0/social-17.0-mail_notification_custom_subject Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_notification_custom_subject/
Currently translated at 100.0% (23 of 23 strings) Translation: social-17.0/social-17.0-mail_notification_custom_subject Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_notification_custom_subject/it/
Currently translated at 95.6% (22 of 23 strings) Translation: social-17.0/social-17.0-mail_notification_custom_subject Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_notification_custom_subject/es/
53162e7
to
9039031
Compare
/ocabot migration mail_notification_custom_subject |
mail_notification_custom_subject/tests/test_mail_notification_custom_subject.py
Outdated
Show resolved
Hide resolved
9039031
to
2ff25e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review ok
Minor comment
2ff25e8
to
cc48904
Compare
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at b5a5ac9. Thanks a lot for contributing to OCA. ❤️ |
Ouch, my fault. This is incorrect and should go to OCA/mail. I'm just force pushing back. |
Removed manually in an extra commit: 808119d and cherry-pick manually all the commits in OCA/mail: https://github.com/OCA/mail/tree/18.0/mail_notification_custom_subject |
Migration to 18.0
Please @pedrobaeza and @sergio-teruel can you review it?
@Tecnativa TT54190