Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][FIX] base_jsonify: In odoo 12, Date and Datetime fields values are d… #1711

Merged
merged 1 commit into from
Oct 30, 2019
Merged

[12.0][FIX] base_jsonify: In odoo 12, Date and Datetime fields values are d… #1711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion base_jsonify/models/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# Raphaël Reverdy <[email protected]>
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).

from odoo import api, models
from odoo import api, fields, models
from odoo.exceptions import UserError
from odoo.tools.translate import _

Expand Down Expand Up @@ -71,6 +71,10 @@ def jsonify(self, parser):
value = rec[field_name]
if value is False and field_type != 'boolean':
value = None
elif field_type == "date":
value = fields.Date.to_string(value)
elif field_type == "datetime":
value = fields.Datetime.to_string(value)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to be compliant with ISO 8601 here.
Date is ok, but date_time defined here https://github.com/odoo/odoo/blob/12.0/odoo/tools/misc.py#L568
is with a space as separator between dates and time. Plus it's lacking timezone.

https://www.w3.org/TR/NOTE-datetime

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmignon have you seen this comment? Sounds important to me too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbidoul Yes I see it, I'll provide a new PR to fix this.

res[json_key] = value
result.append(res)
return result
10 changes: 8 additions & 2 deletions base_jsonify/tests/test_get_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Copyright 2017 ACSONE SA/NV
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).

from odoo import fields
from odoo.tests.common import TransactionCase


Expand Down Expand Up @@ -54,7 +55,9 @@ def test_json_export(self):
]),
('country_id:country', ['code', 'name']),
'active',
('category_id', ['name'])
('category_id', ['name']),
'create_date',
'date',
]
partner = self.env['res.partner'].create({
'name': 'Akretion',
Expand All @@ -67,6 +70,7 @@ def test_json_export(self):
'country_id': self.env.ref('base.fr').id
})
],
'date': fields.Date.today()
})
expected_json = {
'lang': 'en_US',
Expand All @@ -91,7 +95,9 @@ def test_json_export(self):
'children': [],
'name': 'Sebatien Beau',
'email': None
}]
}],
'create_date': fields.Datetime.to_string(partner.create_date),
'date': fields.Date.to_string(partner.date)
}
json_partner = partner.jsonify(parser)

Expand Down