[FIX] search_engine_image_thumbnail: fix the domain type for image fields filter #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @lmignon, |
|
@kobros-tech Can you fix the tests and pre-commit? Thank you for your debugging and correction work. |
kobros-tech
force-pushed
the
16.0_search_engine_image_thumbnail_fix_domain_type
branch
2 times, most recently
from
784320e to
5dee1ab
Compare
|
@lmignon |
kobros-tech
force-pushed
the
16.0_search_engine_image_thumbnail_fix_domain_type
branch
from
5dee1ab to
c44fb08
Compare
lmignon
approved these changes
Oct 9, 2024
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 3398f4e. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The datatype of the domain in the computed method was not correct.
It is reviewed with ACSONE.
It is an extension of a closed pull request:
#198
@lmignon