16.0 ref sale triple discount with cherry pick #3615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now, the triple discount feature did use the standard Odoo field as the first discount field, adding only extra fields for the second and the third discount. This implied we had to override any function using discount to consider the other discounts properly. By adding an extra field discount1 to store the first discount, it allows to redefine the standard discount field to a computed field that will consolidate the triple discount from the other fields, and avoid the need to redefine anything relying on the discount field as it will already consider the triple discounts.
Fix computed fields dependencies The issue with actual implementation is that discount is already a computed field in std Odoo (eg to apply discount from pricelist). Therefore, the value computed by Odoo must be stored in another field, (ie discount1) for discount to be used to consolidate the multiple discount. For this, we assign _compute_discount as the compute of discount1 and redefine a new function to compute discount as consolidated from the other discount fields. Manually bump major version to play upgrade script Fix migration script import Fix init discount from pricelist
…ibles and can not work together by design. similar to account_invoice_fixed_discount and account_invoice_triple_discount
|
Hi @AshishHirapara, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not review, just for CI test.