Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] [16.0] sale_stock_expiry_date_on_qty_at_date_widget #3594

Open
wants to merge 2 commits into
base: 16.0
Choose a base branch
from
Open

[ADD] [16.0] sale_stock_expiry_date_on_qty_at_date_widget #3594

wants to merge 2 commits into from

Conversation

Shide
Copy link
Contributor

@Shide Shide commented Feb 25, 2025

Add a predicted expiration date on Qty at Date Widget.
Also shows a button to see Quants and a Kanban view to see Quants.

MT-8827 @moduon @rafaelbn @yajo @fcvalgar @Gelojr please review if you want 😄

@rafaelbn rafaelbn added this to the 16.0 milestone Feb 25, 2025
rafaelbn
rafaelbn approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA 👍🏼

https://www.loom.com/share/ad97763ac2734aea96f8e814ccfca7e8?sid=cd27ee82-ba09-4d27-998a-81b9fc969f1a

@Shide Shide force-pushed the 16.0-sale_stock_expiry_date_on_qty_at_date_widget branch from b85aaff to 6b5cb13 Compare February 26, 2025 07:01
yajo
yajo requested changes Feb 26, 2025
View reviewed changes
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks amazing, thanks!

I added a few comments, but they are mostly about cosmetic stuff and docs. However, some are issues.

@yajo
Copy link
Member

yajo commented Feb 26, 2025

Suggestion for a slightly shorter technical module name: sale_stock_qty_at_expiry_date

@Shide Shide force-pushed the 16.0-sale_stock_expiry_date_on_qty_at_date_widget branch from 6b5cb13 to c4792c6 Compare February 26, 2025 10:17
@Shide Shide requested a review from yajo February 26, 2025 10:17
fcvalgar
fcvalgar approved these changes Feb 26, 2025
View reviewed changes
Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review,

LGTM, thank you man @Shide

image

image

Gelojr
Gelojr approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@Gelojr Gelojr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice @Shide. Is the predicted expiration date of the oldest quant, isn't it?

yajo
yajo approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-3594-by-yajo-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 27, 2025
@OCA-git-bot
Merge PR #3594 into 16.0
a2dd260 
Signed-off-by yajo
@OCA-git-bot
Copy link
Contributor

@yajo your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-3594-by-yajo-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@yajo
Copy link
Member

yajo commented Feb 27, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-3594-by-yajo-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 27, 2025
@OCA-git-bot
Merge PR #3594 into 16.0
f613719 
Signed-off-by yajo
@Shide
Copy link
Contributor Author

Shide commented Feb 27, 2025

LGTM. Nice @Shide. Is the predicted expiration date of the oldest quant, isn't it?

Is the expiration date of the quant (lot) that will be used if you confirm the order and reserve the quantities in that moment.
The reservation method set on the Category of the Product is taken in consideration (FIFO, FEFO, etc)

@OCA-git-bot
Copy link
Contributor

@yajo your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-3594-by-yajo-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

Shide added 2 commits March 7, 2025 10:09
@Shide
[ADD] sale_stock_expiry_date_on_qty_at_date_widget
ea67aff
@Shide
[FIX] *_triple_discount, *_fixed_discount rebel module groups
ed97c0b 
Added 2 groups of rebel_module_groups:
- sale_order_general_discount_triple,sale_pricelist_triple_discount,sale_triple_discount
- sale_fixed_discount
@Shide Shide force-pushed the 16.0-sale_stock_expiry_date_on_qty_at_date_widget branch from 2dbc1ba to ed97c0b Compare March 7, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yajo yajo yajo approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

@fcvalgar fcvalgar fcvalgar approved these changes

@Gelojr Gelojr Gelojr approved these changes

Assignees
No one assigned
Labels
approved needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Shide @yajo @OCA-git-bot @rafaelbn @fcvalgar @Gelojr