Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] report_qweb_element_page_visibility: use display for element visibility #882

Merged
merged 1 commit into from
Oct 22, 2024
Merged

[16.0][IMP] report_qweb_element_page_visibility: use display for element visibility #882

merged 1 commit into from
Oct 22, 2024

Conversation

david-s73
Copy link

Cherry-pick of #702

@sbejaoui @david-s73
[IMP] - use display for element visibility
c03e250 
the visibility attribute with the hidden option hides the element but
don't free the space.

A common use case is to have a specific header for the first page and
another for the other pages. With visibility: hidden the second header
cannot take the first one place and will keep a huge margin.
One solution is to use the display:none instead.
flotho
flotho approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy forward
LGTM
Thanks

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 6, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 6, 2024
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 20, 2024
@HviorForgeFlow
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-882-by-HviorForgeFlow-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 22, 2024
@OCA-git-bot
Merge PR #882 into 16.0
6a35ee9 
Signed-off-by HviorForgeFlow
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-882-by-HviorForgeFlow-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 22, 2024
@OCA-git-bot
Merge PR #882 into 16.0
fb8ee7a 
Signed-off-by HviorForgeFlow
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-882-by-HviorForgeFlow-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6890084 into OCA:16.0 Oct 22, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ccffc13. Thanks a lot for contributing to OCA. ❤️

@StefanRijnhart StefanRijnhart mentioned this pull request Feb 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flotho flotho flotho approved these changes

@ioans73 ioans73 ioans73 approved these changes

@HviorForgeFlow HviorForgeFlow HviorForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@david-s73 @HviorForgeFlow @OCA-git-bot @flotho @ioans73 @sbejaoui