Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] base_comment_template #876

Merged
merged 79 commits into from
Jul 23, 2024
Merged

[17.0][MIG] base_comment_template #876

merged 79 commits into from
Jul 23, 2024

Conversation

alan196
Copy link
Contributor

@alan196 alan196 commented May 3, 2024

No description provided.

guewen and others added 30 commits May 3, 2024 09:51
@guewen @alan196
Rename base_condition_template to base_comment_template
edb98ae
@alan196
[MIG] base_comment_template to 9.0
cb8d66f
@clb-openfire @alan196
[MIG] base_comment_template, invoice_comment_template: Migration to 10.0
f603b9f 
Port modules base_comment_template and invoice_comment_template to V10
@xavierjimenez @alan196
[MIG] base_comment_template: Migration to 11.0
ad18d1d 
OCA Transbot updated translations from Transifex

OCA Transbot updated translations from Transifex

OCA Transbot updated translations from Transifex
@rven @alan196
[MIG] base_comment_template: Migration to 12.0
b984c11
@mvrodriguez @alan196
Translated using Weblate (Galician)
c682bc4 
Currently translated at 100.0% (15 of 15 strings)

Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/gl/

[ADD] icon.png
@yostashiro @alan196
Translated using Weblate (Japanese)
9180387 
Currently translated at 100.0% (15 of 15 strings)

Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/ja/
@pedrocs-exo @alan196
Translated using Weblate (Portuguese)
33007a9 
Currently translated at 100.0% (15 of 15 strings)

Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/pt/
@alan196
Translated using Weblate (Portuguese (Brazil))
4e960f3 
Currently translated at 100.0% (15 of 15 strings)

Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/pt_BR/
@alan196
[IMP] base_comment_template multi company rules
1324c58 
[IMP] Move comment_template_id from account_invoice_comment_template and make it company_dependant

[IMP] base_comment_template: Add test
@alan196
[IMP] account_invoice_comment_template: Move comment_template_id fiel…
d35307e 
…d to the Invoicing tab

[IMP] account_invoice_comment_template: rename partner field name from comment_template_id to invoice_comment_template_id

[IMP] account_invoice_comment_template: Make partner field company_dependant and move domain definition of invoice fields from the view to the model

[MOV] account_invoice_comment_template: comment_template_id to base_comment_template

[IMP] account_invoice_comment_template: Translate templates when partner changes
@alan196
[MOV] migration script to base_comment_template
02af0d6 
[UPD] README.rst

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/
@alan196
Translated using Weblate (Portuguese (Brazil))
e994263 
Currently translated at 100.0% (21 of 21 strings)

Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/pt_BR/
@pedrocs-exo @alan196
Translated using Weblate (Portuguese)
fd2fb11 
Currently translated at 100.0% (21 of 21 strings)

Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/pt/
@badbole @alan196
Translated using Weblate (Croatian)
2f921f1 
Currently translated at 95.2% (20 of 21 strings)

Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/hr/
@pedrobaeza @alan196
[FIX] base_comment_template: Make field truly company dependent
0610dc3 
Previous field declaration was incorrect due to a typo, leading to non applying the
company dependent features.

Now everything is correct and the migration scripts care of moving data properly.
@pedrobaeza @alan196
[FIX] base_comment_template: Make field truly company dependent
c8af2bb 
Previous field declaration was incorrect due to a typo, leading to non applying the
company dependent features.

Now everything is correct and the migration scripts care of moving data properly.
@marylla @alan196
Translated using Weblate (German)
e5ddb8e 
Currently translated at 100.0% (21 of 21 strings)

Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/de/
@pedrocs-exo @alan196
Translated using Weblate (Portuguese (Portugal))
61f9bfa 
Currently translated at 100.0% (21 of 21 strings)

Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/pt_PT/
@jprokop1 @alan196
Translated using Weblate (Slovak)
c2fa5eb 
Currently translated at 100.0% (21 of 21 strings)

Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/sk/

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/
@pedrobaeza @alan196
[MIG+FIX] base_comment_template: Fix migration scripts
7f1701c 
As the field was not properly converted to property at 2.0.0, the script fails to do its
job when migrating from v11, so we need to adapt the scripts to this situation.
@petrus-v @alan196
[IMP] base_comment_template: black, isort, prettier
fa2a677
@petrus-v @alan196
[MIG] base_comment_template: Migration to 14.0 add unit test
2b3dce5 
[UPD] Update base_comment_template.pot

[UPD] README.rst
@feketemihai @alan196
[MIG] [13.0] Migrate base_comment_template from account_invoic_report…
9daf0f6 
…ing.
@alan196
[IMP] base_comment_template: Code refactorization
f47b821
@CarlosRoca13 @alan196
[IMP] base_comment_template: Improved sentences on fields
2dfe6cc
@victoralmau @alan196
[IMP] base_comment_template: Add function to get_comment_template rec…
0d8cdef 
…ords
@victoralmau @alan196
[FIX] base_comment_template: Fix tests: test_company_general_template
6c63370
@victoralmau @alan196
[FIX] base_comment_template: Change domain in rule according to company
ea64cd2
@victoralmau @alan196
[IMP] base_comment_template: Refactor code and convert to Many2Many
29842b1
weblate and others added 10 commits May 3, 2024 09:51
@weblate @alan196
Update translation files
6fea7cd 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: reporting-engine-16.0/reporting-engine-16.0-base_comment_template
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-base_comment_template/
@matteonext @alan196
[IMP]base_comment_template: using markup.safe to render html in report
2ec8a0e
@OCA-git-bot @alan196
[BOT] post-merge updates
189ff51
@mymage @alan196
Translated using Weblate (Italian)
d0785d1 
Currently translated at 57.1% (36 of 63 strings)

Translation: reporting-engine-16.0/reporting-engine-16.0-base_comment_template
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-base_comment_template/it/
@OCA-git-bot @alan196
[BOT] post-merge updates
575b0b5
@mymage @alan196
Translated using Weblate (Italian)
31446d7 
Currently translated at 100.0% (63 of 63 strings)

Translation: reporting-engine-16.0/reporting-engine-16.0-base_comment_template
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-base_comment_template/it/
@alan196
[IMP] base_comment_template: update readme files
57b582f 
Change deprecated t-raw to t-out.
Rename invoice_comment_template to account_comment_template
@OCA-git-bot @alan196
[BOT] post-merge updates
e1e49f8
@alan196
[IMP] base_comment_template: pre-commit auto fixes
7234782
@alan196
[MIG] base_comment_template: Migration to 17.0
e3abb35
This was referenced May 3, 2024
Open
Closed
Closed
@BT-pkosnik BT-pkosnik mentioned this pull request Jul 5, 2024
Merged
@HaraldPanten
Copy link

@pedrobaeza @etobella could we merge this one? It's needed by sale_comment template, account_comment template, etc.

THX

@RogerSans
Copy link

Technical Review: LGTM

@etobella
Copy link
Member

/ocabot migration base_comment_template

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jul 23, 2024
@etobella
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-876-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ef23fdb into OCA:17.0 Jul 23, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 76a3b60. Thanks a lot for contributing to OCA. ❤️

@alan196 alan196 deleted the 17.0-mig-base_comment_template branch July 23, 2024 15:57
@RogerSans RogerSans mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etobella etobella etobella approved these changes

@HaraldPanten HaraldPanten HaraldPanten approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.