-
-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] sql_request_abstract + bi_sql_editor: Migration to 17.0 #832
[17.0][MIG] sql_request_abstract + bi_sql_editor: Migration to 17.0 #832
Conversation
…ield; [ADD] security
…fresh date time on the action name of each sql materialized view
Fix error '... is not a table or foreign table' Fix view (colors + oe_highlight) Fix tests Fix README + manifest Fix back to draft Fix cron call + default values Use Postgres version 9.6 for travis builds
* [IMP] is_materialized field non readonly on sql_valid state ; [FIX] block possibility to set indexes on non materialized view * [FIX] set domain_force, group_ids readonly if state > sql_valid * [IMP] better display of the field group_ids * [IMP] possibility to reorder menu items from sql views * [IMP] Do not warn user when setting sql view to draft if state is sql_valid * [REF] * [FIX] Set Date of the first execution in the action name
[UPD] Update bi_sql_editor.pot [UPD] Update bi_sql_editor.pot [UPD] Update bi_sql_editor.pot
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
bi_sql_editor 12.0.1.1.0 [UPD] README.rst [UPD] README.rst
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-12.0/reporting-engine-12.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-bi_sql_editor/
Currently translated at 29.1% (32 of 110 strings) Translation: reporting-engine-12.0/reporting-engine-12.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-bi_sql_editor/de/
…on') in tree view
…nly into 'draft' state
…ated to field_description, as this field is required and so, allways defined
…le to implement that feature with optional='hide' on the field list view
…del Valid'. Avoid to reset to draft and to have to recreate view that can take a while, if the view is materialized
451f10f
to
5076fab
Compare
Updated |
/ocabot migration bi_sql_editor |
5076fab
to
c8471a0
Compare
@legalsylvain can I merge this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. @nguyenminhchien. thanks for porting this module !
Blocking point : I don't understand why you changed all the readonly state defined by python in readonly state defined by xml. Could you elaborate ?
nitpicking : could you squash the two "MIG V17" commits ? it ll make the review easier.
thanks !
Hi @legalsylvain
There is only 1 "MIG V17" commit for each module, following the guideline from https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0#tasks-to-do-in-the-migration . I think we should not squash them just for making review easier . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation.
/ocabot merge patch
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 304c394. Thanks a lot for contributing to OCA. ❤️ |
Ref: BSRD-736