[16.0][MIG] project_task_code : alternative without functionality change #1209

robinkeunen · 2023-12-20T14:35:56Z

This PR is an alternative to #1084.

In 15.0 : project_task_code

adds code field on tasks
adds sql contraint project_task_unique_code
a hook initializes code from project.task sequence
in create, code is assigned from project.task sequence

In his migration review (2023-03-27), @rafaelbn pointed out that the a configuration should be added for the constraint. Otherwise, it breaks the tests from other modules.

I understand from the suggestion that the module should

add the task code upon installation
force the unicity constraint on configuration

The fix in #1084 does the opposite, it

forces the unicity constraint upon installation
creates the task code on configuration

It has the advantage of making the module multi-company compliant but at the coast of - according to me - changing the functionality of the module.

I leave it to the PSC to choose the most appropriate PR :-)

rafaelbn · 2023-12-26T17:04:47Z

/ocabot migration project_task_code

OCA-git-bot · 2023-12-26T17:04:58Z

The migration issue (#988) has not been updated to reference the current pull request because a previous pull request (#1084) is not closed.
Perhaps you should check that there is no duplicate work.
CC @Abranes

ivs-cetmix · 2023-12-30T15:07:23Z

project_task_code/models/project_task.py

+        string="Task Number",
+        required=True,
+        default="/",
+        readonly=True,


Not for migration: What is the reason behind keeping this field readonly?

Because it is generated through a sequence :-)

ivs-cetmix

Functional review LGTM. Using this module in prod already)

Shide

I'm ok with this, but If in the future happens something that breaks runboat, will be good to modify the module.

The runboat break happens to me in this PR: #1096 (comment)

robinkeunen · 2024-01-11T15:17:25Z

I'm sorry this is going back and forth that way, not trying to be a troll ... :/

I actually was convinced by @huguesdk and @legalsylvain 's comment on #1084 . I see no reason why the sql constraint would conflict w/ other module since the field code is added by this module.

I wonder if the error you had in v15 was due to the constraint checking unicity on the code but not on the company ? We'll see and fix if it rises again.

robinkeunen · 2024-01-11T15:20:11Z

Last 3 commits should be smashed.

robinkeunen · 2024-01-11T15:22:27Z

Hi @dreispt , can you take a look at this PR ? It raised many concerns in #1084 and #1013 . It would be great to finally settle it :-)

OCA-git-bot · 2024-01-11T15:47:20Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

huguesdk

@robinkeunen thanks for this. would you please squash the last 3 commits?

Currently translated at 50.0% (3 of 6 strings) Translation: project-14.0/project-14.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_task_code/fr_FR/

Currently translated at 100.0% (3 of 3 strings) Translation: project-14.0/project-14.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_task_code/es_MX/

Currently translated at 100.0% (3 of 3 strings) Translation: project-14.0/project-14.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_task_code/sv/

Currently translated at 100.0% (3 of 3 strings) Translation: project-15.0/project-15.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_task_code/ca/

The overload of project.task::create in the project_task_code would mutate the dictionaries passed in the vals_list argument. This is a bad practice which can have unintended side effects in caller code. We fix this by creating a new dictionary containing the additional field value and passing this dictionary in the call to super().create()

…olates not-null constraint

Currently, the sequence that generates task codes is only available for the main company [1], which could cause issues at the moment of the installation process with another modules in multi-companies cases, for example project_timesheet_holiday [2] because in the other companies, this line [3] will return False or "/" and will trigger the UNIQUE constraint. With this change, the sequence can be used by any company [4] using the False value in the field company_id. References: [1] https://github.com/odoo/odoo/blob/7b6c25e/odoo/addons/base/models/ir_sequence.py#L148 [2] https://github.com/odoo/odoo/blob/7b6c25e/addons/project_timesheet_holidays/models/res_company.py#L14 [3] https://github.com/OCA/project/blob/9d08f2d/project_task_code/models/project_task.py#L29 [4] https://github.com/odoo/odoo/blob/7b6c25e/odoo/addons/base/models/ir_sequence.py#L282

rafaelbn · 2024-01-13T20:43:19Z

/ocabot migration project_task_code

rafaelbn · 2024-01-13T20:45:06Z

@legalsylvain , are you PSC here to merge?

legalsylvain · 2024-01-13T21:21:03Z

Nop !
Here is the list : https://github.com/OCA/repo-maintainer-conf/blob/master/conf/psc/project.yml

rafaelbn

/ocabot merge patch

Merging as long discussed in other PR, but if any issue I will ping you 😄

OCA-git-bot · 2024-01-13T21:46:57Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1209-by-rafaelbn-bump-patch, awaiting test results.

OCA-git-bot · 2024-01-13T21:53:27Z

Congratulations, your PR was merged at 9bbf8b5. Thanks a lot for contributing to OCA. ❤️

robinkeunen · 2024-01-15T14:08:24Z

🙏 that was a long one, thanks @Shide and @Abranes

robinkeunen mentioned this pull request Dec 20, 2023

[16.0][MIG] project_task_code #1084

Closed

robinkeunen force-pushed the 16.0-mig-project_task_code-roke branch from 87b6fbc to c04a2de Compare December 20, 2023 14:38

rafaelbn requested a review from Shide December 26, 2023 17:04

OCA-git-bot added this to the 16.0 milestone Dec 26, 2023

rafaelbn added needs review migration labels Dec 26, 2023

ivs-cetmix reviewed Dec 30, 2023

View reviewed changes

ivs-cetmix approved these changes Jan 9, 2024

View reviewed changes

Shide approved these changes Jan 10, 2024

View reviewed changes

OCA-git-bot added the approved label Jan 10, 2024

Abranes approved these changes Jan 10, 2024

View reviewed changes

robinkeunen requested review from Shide, ivs-cetmix and Abranes January 11, 2024 15:20

OCA-git-bot added the ready to merge label Jan 11, 2024

huguesdk approved these changes Jan 12, 2024

View reviewed changes

Shide approved these changes Jan 12, 2024

View reviewed changes

oihane and others added 7 commits January 12, 2024 17:44

[MOD] changing from odoomrp to avanzosc

9727e87

[FIX] Code error when copying a task

afee2fe

[IMP] <project_task_code> adapted to OCA

3086c28

[IMP] <project_task_code> Added docstring to pre and post init-hooks

11ee2ba

[UPD] prefix versions with 8.0

b73c83e

[MIG] Make modules uninstallable

f44edee

[MIG] Rename manifest files

6ad0f61

Yvesldff and others added 16 commits January 12, 2024 17:44

Translated using Weblate (French (France))

67f1578

Currently translated at 50.0% (3 of 6 strings) Translation: project-14.0/project-14.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_task_code/fr_FR/

Translated using Weblate (Spanish (Mexico))

a45a624

Currently translated at 100.0% (3 of 3 strings) Translation: project-14.0/project-14.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_task_code/es_MX/

Translated using Weblate (Swedish)

8e05c8e

Currently translated at 100.0% (3 of 3 strings) Translation: project-14.0/project-14.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_task_code/sv/

[MIG] project_task_code : Migrate project_task_code.

8d695a7

[UPD] Update project_task_code.pot

3917981

[UPD] README.rst

1fa12b2

Translated using Weblate (Catalan)

a473195

Currently translated at 100.0% (3 of 3 strings) Translation: project-15.0/project-15.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_task_code/ca/

project_task_code 15.0.1.0.2

0ef2e4d

[15.0][FIX] project_task_code: Fix null value in column code, that vi…

3b668d7

…olates not-null constraint

project_task_code 15.0.1.0.3

de2f16e

[IMP] update dotfiles [ci skip]

772df0d

project_task_code 15.0.1.0.4

d71ca2f

[MIG] project_task_code: Migration to 16.0

95494ab

[FIX] project_task_code: unique code in company

2ca302e

robinkeunen force-pushed the 16.0-mig-project_task_code-roke branch from 30e58be to 2ca302e Compare January 12, 2024 16:47

OCA-git-bot mentioned this pull request Jan 13, 2024

Migration to version 16.0 #988

Open

38 tasks

rafaelbn approved these changes Jan 13, 2024

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Jan 13, 2024

OCA-git-bot merged commit dc799f5 into OCA:16.0 Jan 13, 2024
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jan 13, 2024

robinkeunen deleted the 16.0-mig-project_task_code-roke branch January 15, 2024 14:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] project_task_code : alternative without functionality change #1209

[16.0][MIG] project_task_code : alternative without functionality change #1209

robinkeunen commented Dec 20, 2023 •

edited

Loading

rafaelbn commented Dec 26, 2023

OCA-git-bot commented Dec 26, 2023

ivs-cetmix Dec 30, 2023

robinkeunen Jan 11, 2024

ivs-cetmix left a comment

Shide left a comment

robinkeunen commented Jan 11, 2024 •

edited

Loading

robinkeunen commented Jan 11, 2024

robinkeunen commented Jan 11, 2024

OCA-git-bot commented Jan 11, 2024

huguesdk left a comment

rafaelbn commented Jan 13, 2024

rafaelbn commented Jan 13, 2024

legalsylvain commented Jan 13, 2024

rafaelbn left a comment

OCA-git-bot commented Jan 13, 2024

OCA-git-bot commented Jan 13, 2024

robinkeunen commented Jan 15, 2024

[16.0][MIG] project_task_code : alternative without functionality change #1209

[16.0][MIG] project_task_code : alternative without functionality change #1209

Conversation

robinkeunen commented Dec 20, 2023 • edited Loading

rafaelbn commented Dec 26, 2023

OCA-git-bot commented Dec 26, 2023

ivs-cetmix Dec 30, 2023

Choose a reason for hiding this comment

robinkeunen Jan 11, 2024

Choose a reason for hiding this comment

ivs-cetmix left a comment

Choose a reason for hiding this comment

Shide left a comment

Choose a reason for hiding this comment

robinkeunen commented Jan 11, 2024 • edited Loading

robinkeunen commented Jan 11, 2024

robinkeunen commented Jan 11, 2024

OCA-git-bot commented Jan 11, 2024

huguesdk left a comment

Choose a reason for hiding this comment

rafaelbn commented Jan 13, 2024

rafaelbn commented Jan 13, 2024

legalsylvain commented Jan 13, 2024

rafaelbn left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Jan 13, 2024

OCA-git-bot commented Jan 13, 2024

robinkeunen commented Jan 15, 2024

robinkeunen commented Dec 20, 2023 •

edited

Loading

robinkeunen commented Jan 11, 2024 •

edited

Loading