[16.0][mig] project_timesheet_time_control #1133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Decorate methods correctly + README imp * Add tests * Add button on tasks * Better README * open/close behaviour
Update README Adapt tests Redefine the new kanban and form view of account.analytic.line to add 'Close/Open task' button and 'Stop' button
We need to override standard onchange, as it resets the previously introduced task.
Currently translated at 100.0% (8 of 8 strings) Translation: project-12.0/project-12.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_timesheet_time_control/pt_BR/
This is a huge improvement in this module's usability, although basic functionality stays the same. Let me summmarize: - In `account.analytic.line` views, the *Stop* button is replaced by colorful *Resume/Stop* buttons. - The new *Resume* button will display a wizard that will duplicate all meaningful fields from the previous `account.analytic.line` record and auto-stop the previous running timer, if any. - If the previous running timer is very old, some warnings will be displayed. - In `project.project` and `project.task` views, I added the same buttons (well... it's *Start* instead of *Resume*, because you could not have worked before in that project or task, but it behaves the same). - If using it from a `project.task`, *Start* will duplicate meaningful fields from your latest line in that task. - If using it from a `project.project`, *Start* will duplicate meaningful fields your latest line in that project that had no task associated. - All kanban, kanban mobile, list and form views are covered. - Access the new wizard directly from a menu item if you prefer. - I removed, BTW, some Bootstrap 3 and bad replacements in some views.
…as found Imagine this scenario: 1. In tab 1 of the browser, you have opened task 1. 2. In tab 2 of the browser, you have opened task 2. 3. You go to tab 1 and start a timer. 4. Work, work, work... 5. You go to tab 2 and start a timer, stopping that of task 1. 6. Work, work, work... 7. You go to tab 1 and see that timer as running (it is not, but you didn't refresh). You hit stop. Before this commit, it just seemed like the timer was actually stopped. What did happen behind the scenes is that your view was refreshed, but no timer was touched fortunately. After this commit, you get a message telling you that there's no timer to stop and that your browser is most likely out of sync. This mimics the behavior previously found when doing the same, but directly in the AAL. Now it's present in projects and tasks too.
Models related to timesheet time controls now inherit from a mixin that adds most needed logic automatically.
Currently translated at 32.3% (20 of 62 strings) Translation: project-12.0/project-12.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_timesheet_time_control/sl/
Currently translated at 7.9% (5 of 63 strings) Translation: project-12.0/project-12.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_timesheet_time_control/de/
- Standard procedure - README regeneration - Start new timer little adjustment - Avoid new check for shared m2m tables
…t when setting date field
…ctivity_begin_end module Prior to this commit, trying to resume an activity which had a start time or end time set would cause the newly created timesheet to throw a validation error because time_stop - time_start must equal duration. This commit fixes that issues by adding those fields to the ignore list
…esheet This commit adds a field to the timesheet to store the end time. It is not required to enter the end time, if it is not entered it is calculated automatically by comparing the start time and the duration, if only a start time and end time are entered, then the duration is calculated accordingly. The end time field is set to optional in the tree view.
Currently translated at 100.0% (67 of 67 strings) Translation: project-13.0/project-13.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_timesheet_time_control/he_IL/
Currently translated at 16.4% (11 of 67 strings) Translation: project-13.0/project-13.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_timesheet_time_control/de/
Currently translated at 67.1% (45 of 67 strings) Translation: project-13.0/project-13.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_timesheet_time_control/nl/
Currently translated at 86.5% (58 of 67 strings) Translation: project-13.0/project-13.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_timesheet_time_control/nl/
Currently translated at 88.0% (59 of 67 strings) Translation: project-13.0/project-13.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_timesheet_time_control/nl/
Currently translated at 100.0% (67 of 67 strings) Translation: project-14.0/project-14.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_timesheet_time_control/es_AR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-15.0/project-15.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_timesheet_time_control/
Currently translated at 100.0% (48 of 48 strings) Translation: project-15.0/project-15.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_timesheet_time_control/es_AR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-15.0/project-15.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_timesheet_time_control/
Currently translated at 100.0% (49 of 49 strings) Translation: project-15.0/project-15.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_timesheet_time_control/es_AR/
Currently translated at 100.0% (49 of 49 strings) Translation: project-15.0/project-15.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_timesheet_time_control/es/
Error: AttributeError: type object 'expression' has no attribute AND
That way, we don't have an error coming from the previous version
Currently translated at 100.0% (49 of 49 strings) Translation: project-15.0/project-15.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_timesheet_time_control/it/
Currently translated at 100.0% (49 of 49 strings) Translation: project-15.0/project-15.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_timesheet_time_control/it/
Currently translated at 100.0% (49 of 49 strings) Translation: project-15.0/project-15.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_timesheet_time_control/it/
Currently translated at 100.0% (49 of 49 strings) Translation: project-15.0/project-15.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_timesheet_time_control/it/
…oup to company_id field from wizard
Currently translated at 100.0% (49 of 49 strings) Translation: project-15.0/project-15.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_timesheet_time_control/it/
|
Hi @heliaktiv, |
| @@ -145,8 +144,6 @@ def test_aal_without_start_resume_button(self): | |||
| """If a line has no start date, can only resume it.""" | |||
| self.assertEqual(self.line.show_time_control, "stop") | |||
| self.line.date_time = False | |||
| self.line.invalidate_cache() | |||
| self.assertEqual(self.line.show_time_control, "resume") | |||
There was a problem hiding this comment.
Why are you removing this checks?
|
You can remove the dependencies of |
|
Hi @stefan-tecnativa . |
|
Hi. |
|
@heliaktiv Dependencies have already been merged |
|
Superseded by #1148 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.