[16.0][FW] [15.0][IMP] product_pricelist_direct_print: Allow printing the products sold to a client from x date #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @legalsylvain, |
carlosdauden
approved these changes
Feb 4, 2025
Comment on lines
+280
to
+282
| domain = expression.AND( | ||
| [domain, [("date_order", ">=", self.product_selling_date_threshold)]] | ||
| ) |
There was a problem hiding this comment.
Suggested change
| domain = expression.AND( | |
| [domain, [("date_order", ">=", self.product_selling_date_threshold)]] | |
| ) | |
| domain.append(("date_order", ">=", self.product_selling_date_threshold)) |
I know I review the PR in the previous version and I didn't put this suggestion, but seeing that it's a very simple domain we can save ourselves the use of expression.AND.
There was a problem hiding this comment.
expression.AND is more explicit. And that is exactly the objective of this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port from 15.0 to 16.0: