[ADD] product_top_category #1173

victor-champonnois · 2022-10-21T08:42:28Z

No description provided.

legalsylvain · 2022-10-21T08:49:04Z

product_top_category/models/product_category.py

+
+    # what if there is a change in parent of parent ? how to trigger the compute ?
+    # note : the field is store as related in product.template
+    @api.depends('parent_id')


You could dépend on parent_id.top_categ_id. Dont you think ?

Yes, good idea thanks :)

victor-champonnois · 2022-10-27T08:17:58Z

@legalsylvain any idea why travis is failing ? The error is

January 2021. pip 21.0 will remove support for this functionality.

ERROR: Could not find a version that satisfies the requirement pylint-plugin-utils==0.7 (from -r /home/travis/maintainer-quality-tools/travis/pylint_odoo_requirements.txt (line 1)) (from versions: 0.1, 0.1.1, 0.2, 0.2.1, 0.2.2, 0.2.3, 0.2.4, 0.2.6, 0.3, 0.4, 0.5, 0.6)

ERROR: No matching distribution found for pylint-plugin-utils==0.7 (from -r /home/travis/maintainer-quality-tools/travis/pylint_odoo_requirements.txt (line 1))

The command "travis_install_nightly" failed and exited with 1 during

legalsylvain · 2022-10-27T08:41:21Z

Travis is totally obsolete. I guess that switching to github action could solve the problem, updating technical files in the root folder (in a dedicated PR).
do you know how to do that ?

otherwise, you can ask to @carmenbianca I think.

robinkeunen

Small comments otherwise LGTM 👍

robinkeunen · 2022-10-28T14:36:23Z

product_top_category/models/product_category.py

+    def _get_top_category(self):
+        self.ensure_one()
+        if self.parent_id:
+            return(self.parent_id._get_top_category())


Why the parentheses ?

ah, don't know, it just came naturally ^^ I remove them

robinkeunen · 2022-10-28T14:39:10Z

product_top_category/readme/DESCRIPTION.rst

@@ -0,0 +1,3 @@
+For all categories, compute their top categories. 


Maybe add that this field is useful for reports and pivot views ?

victor-champonnois · 2022-10-31T09:48:23Z

@robinkeunen thanks for the review !

legalsylvain · 2022-12-07T13:09:24Z

Hi. could you solve travis issue, updating files in another PR via copier template ? (then rebasing).

thanks !

victor-champonnois · 2022-12-09T09:33:21Z

Hi. could you solve travis issue, updating files in another PR via copier template ? (then rebasing).

thanks !

Done here, it still doesn't seem to work though. @carmenbianca do you have an idea why ?

carmenbianca · 2022-12-15T08:32:52Z

@victor-champonnois In the meantime, the template broke again 😅

OCA/oca-addons-repo-template#181

Need to bump template again

victor-champonnois · 2022-12-15T09:54:19Z

@carmenbianca updated the copier update branch and rebased on it !

rousseldenis · 2022-12-15T11:07:33Z

@victor-champonnois Easier to do a copier update PR as this one could last again some time. The copier PR could be merged fast. Do you take care of that ?

rousseldenis · 2022-12-15T11:08:22Z

@victor-champonnois Easier to do a copier update PR as this one could last again some time. The copier PR could be merged fast. Do you take care of that ?

Ok, I see it. I'll do the merge

github-actions · 2023-04-16T12:13:35Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

carmenbianca · 2023-05-02T15:22:21Z

Rebasing this.

victor-champonnois · 2023-05-10T12:05:23Z

@rousseldenis this is ready to be merged

rousseldenis · 2023-05-11T07:30:57Z

.pre-commit-config.yaml

@@ -38,6 +38,7 @@ repos:
    rev: v3.4.1
    hooks:
      - id: flake8
+        language_version: python3


@victor-champonnois You should not modify manually.

Maybe could you propose this change to https://github.com/OCA/oca-addons-repo-template/blob/master/src/.pre-commit-config.yaml.jinja ?

Thanks

I removed the commit, it wasn't needed actually.

remytms · 2023-07-12T17:55:50Z

@rousseldenis It seams that this PR is now ok to merge. :)

rousseldenis · 2023-07-20T06:54:22Z

product_top_category/models/product_category.py

+        for categ in self:
+            categ.top_categ_id = categ._get_top_category()
+
+    top_categ_id = fields.Many2one('product.category',


@victor-champonnois Could you put fields on ... top :-) ? Thanks

done, thanks for the review :)

OCA-git-bot · 2023-07-20T08:05:27Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

rousseldenis · 2023-07-20T08:05:35Z

/ocabot merge patch

OCA-git-bot · 2023-07-20T08:05:42Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-1173-by-rousseldenis-bump-patch, awaiting test results.

Signed-off-by rousseldenis

OCA-git-bot · 2023-07-20T08:19:17Z

Congratulations, your PR was merged at 5c22fb3. Thanks a lot for contributing to OCA. ❤️

legalsylvain reviewed Oct 21, 2022

View reviewed changes

victor-champonnois marked this pull request as ready for review October 27, 2022 08:17

victor-champonnois mentioned this pull request Oct 27, 2022

[ADD] rotordc_sale_reports_top_category coopiteasy/cie-custom#83

Open

4 tasks

robinkeunen approved these changes Oct 28, 2022

View reviewed changes

victor-champonnois requested a review from legalsylvain December 7, 2022 12:55

victor-champonnois force-pushed the 12.0-add-product_top_category branch 4 times, most recently from a02153c to 0f7aa53 Compare December 9, 2022 09:30

victor-champonnois force-pushed the 12.0-add-product_top_category branch from 0f7aa53 to 571d527 Compare December 15, 2022 09:53

rousseldenis added the needs review label Dec 15, 2022

rousseldenis added this to the 12.0 milestone Dec 15, 2022

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 16, 2023

carmenbianca force-pushed the 12.0-add-product_top_category branch from 571d527 to 2148e0f Compare May 2, 2023 15:24

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 7, 2023

victor-champonnois force-pushed the 12.0-add-product_top_category branch from 2148e0f to e8b44b6 Compare May 10, 2023 09:57

rousseldenis reviewed May 11, 2023

View reviewed changes

victor-champonnois force-pushed the 12.0-add-product_top_category branch from e8b44b6 to 94032a0 Compare May 11, 2023 07:55

victor-champonnois force-pushed the 12.0-add-product_top_category branch from 94032a0 to 5d1f6c0 Compare May 11, 2023 08:07

rousseldenis reviewed Jul 20, 2023

View reviewed changes

victor-champonnois force-pushed the 12.0-add-product_top_category branch 2 times, most recently from 04599f2 to 618f78d Compare July 20, 2023 07:58

[ADD] product_top_category

c7bd592

victor-champonnois force-pushed the 12.0-add-product_top_category branch from 618f78d to c7bd592 Compare July 20, 2023 07:58

rousseldenis approved these changes Jul 20, 2023

View reviewed changes

OCA-git-bot added approved ready to merge labels Jul 20, 2023

OCA-git-bot added the bot is merging ⏳ label Jul 20, 2023

OCA-git-bot added a commit that referenced this pull request Jul 20, 2023

Merge PR #1173 into 12.0

65dce29

Signed-off-by rousseldenis

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jul 20, 2023

OCA-git-bot closed this Jul 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD] product_top_category #1173

[ADD] product_top_category #1173

victor-champonnois commented Oct 21, 2022

legalsylvain Oct 21, 2022

victor-champonnois Oct 21, 2022

victor-champonnois commented Oct 27, 2022

legalsylvain commented Oct 27, 2022

robinkeunen left a comment •

edited

Loading

robinkeunen Oct 28, 2022

victor-champonnois Oct 31, 2022

robinkeunen Oct 28, 2022

victor-champonnois Oct 31, 2022

victor-champonnois commented Oct 31, 2022

legalsylvain commented Dec 7, 2022

victor-champonnois commented Dec 9, 2022

carmenbianca commented Dec 15, 2022

victor-champonnois commented Dec 15, 2022 •

edited

Loading

rousseldenis commented Dec 15, 2022

rousseldenis commented Dec 15, 2022

github-actions bot commented Apr 16, 2023

carmenbianca commented May 2, 2023

victor-champonnois commented May 10, 2023

rousseldenis May 11, 2023

victor-champonnois May 11, 2023

remytms commented Jul 12, 2023

rousseldenis Jul 20, 2023

victor-champonnois Jul 20, 2023

OCA-git-bot commented Jul 20, 2023

rousseldenis commented Jul 20, 2023

OCA-git-bot commented Jul 20, 2023

OCA-git-bot commented Jul 20, 2023

		@@ -0,0 +1,3 @@
		For all categories, compute their top categories.

[ADD] product_top_category #1173

[ADD] product_top_category #1173

Conversation

victor-champonnois commented Oct 21, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

victor-champonnois commented Oct 27, 2022

legalsylvain commented Oct 27, 2022

robinkeunen left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

victor-champonnois commented Oct 31, 2022

legalsylvain commented Dec 7, 2022

victor-champonnois commented Dec 9, 2022

carmenbianca commented Dec 15, 2022

victor-champonnois commented Dec 15, 2022 • edited Loading

rousseldenis commented Dec 15, 2022

rousseldenis commented Dec 15, 2022

github-actions bot commented Apr 16, 2023

carmenbianca commented May 2, 2023

victor-champonnois commented May 10, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

remytms commented Jul 12, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OCA-git-bot commented Jul 20, 2023

rousseldenis commented Jul 20, 2023

OCA-git-bot commented Jul 20, 2023

OCA-git-bot commented Jul 20, 2023

robinkeunen left a comment •

edited

Loading

victor-champonnois commented Dec 15, 2022 •

edited

Loading