Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] partner_country_lang: Migration to 17.0 #1976

Open
wants to merge 4 commits into
base: 17.0
Choose a base branch
from
Open

[17.0][MIG] partner_country_lang: Migration to 17.0 #1976

wants to merge 4 commits into from

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Feb 5, 2025 •
edited
Loading

Migration to 17.0

@Tecnativa TT54939

victoralmau and others added 3 commits February 5, 2025 17:42
@victoralmau
[ADD] partner_country_lang: New addon.
64e224a 
TT38559

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: partner-contact-13.0/partner-contact-13.0-partner_country_lang
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-13-0/partner-contact-13-0-partner_country_lang/
@ernesto-garcia-tecnativa @victoralmau
[MIG] partner_country_lang: Migration to 15.0
4ef7f8c 
[UPD] Update partner_country_lang.pot

[UPD] README.rst

[UPD] README.rst
@victoralmau
[IMP] partner_country_lang: pre-commit stuff
cbb10dc
@pedrobaeza
Copy link
Member

You should convert the onchange to compute and you won't need that dependency switch.

@pedrobaeza
Copy link
Member

/ocabot migration partner_country_lang

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Feb 5, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 5, 2025
Open
67 tasks
@victoralmau victoralmau force-pushed the 17.0-mig-partner_country_lang branch from f128cca to 8697a6f Compare February 5, 2025 17:02
@victoralmau
Copy link
Member Author

You should convert the onchange to compute and you won't need that dependency switch.

Changes done.

@victoralmau victoralmau force-pushed the 17.0-mig-partner_country_lang branch from 8697a6f to 0ce6310 Compare February 6, 2025 07:19
@victoralmau victoralmau force-pushed the 17.0-mig-partner_country_lang branch from 0ce6310 to e49fc9d Compare February 6, 2025 08:03
@pedrobaeza
Copy link
Member

Oh, wait, the CI is red.

@victoralmau
Copy link
Member Author

Oh, wait, the CI is red.

Reviewing the test error happens because the existing ir.default for the lang field causes the en_US language to be defined on creation without going through compute. Is it possible that not doing the compute field initially was intentional to avoid this?

@pedrobaeza
Copy link
Member

If this is not working for create, you should continue overriding the create as it was.

@victoralmau victoralmau force-pushed the 17.0-mig-partner_country_lang branch from e49fc9d to 26a6627 Compare February 6, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
migration needs review
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@victoralmau @pedrobaeza @OCA-git-bot @rousseldenis @ernesto-garcia-tecnativa