Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG][12.0] mgmtsystem_review #251

Merged
merged 16 commits into from
Aug 12, 2019
Merged

Conversation

jcoux
Copy link
Contributor

@jcoux jcoux commented Jun 5, 2019

Migrate module mgmtsystem_review.

Blocked by: #247

@oca-clabot
Copy link

Hey @jcoux, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

  • Marc Cassuto [email protected] (no github login found)
  • Launchpad Translations on behalf of openerp-commiter (no github login found)
  • Maxime Chambreuil [email protected] (no github login found)

Appreciation of efforts,
OCA CLAbot

@jcoux jcoux mentioned this pull request Jun 5, 2019
15 tasks
@pedrobaeza pedrobaeza added this to the 12.0 milestone Jun 5, 2019
@jcoux jcoux force-pushed the 12.0-mig-mgmtsystem_review branch 2 times, most recently from c08505e to 2d9b146 Compare June 5, 2019 12:40
@jcoux jcoux changed the title [WIP][MIG] 12.0 - mgmtsystem_review [MIG][12.0] mgmtsystem_review Jun 5, 2019
Copy link
Member

@gurneyalex gurneyalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review

Copy link
Member

@jgrandguillaume jgrandguillaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Maxime Chambreuil and others added 16 commits August 12, 2019 20:10
* Initial commit. Import from extra-addons.
* cleanup
* Group references. Reported by michaelgiesbrecht on the forum.
* Icons
* Move audittrail dependency from mgmtsystem to requiring modules
…; fixed AGPL-3 reference + .py files licenses to AGPL
* [FIX] Bogus import in mgmtsystem_review.

  The wizard sub-module doesn't exist in this module and in openerp 7.0,
  it caused problems.

* [MIG] Added migration scripts for 0.1 --> 1.0 in the modules that needed it.

  mgmtsystem_nonconformity:

  * o --> open c --> done state change.
  * Migrating action relations to a many2many table.
  * Concatening action comments in a single field

  mgmtsystem_audit and mgmtsystem_review:

  * o --> open c --> done state change.

* [FIX] Fixed "Unknown field state for domain" errors.

  In 7.0, it's necessary, in a view, to have the field present in a view in order to use it
  in a domain. I added an invisible "state" field in relevant views to fix the errors.

* [IMP] Updated statusbar/buttons's layout to conform to OpenERP 7.0 style.

  Instead of a group at the bottom of the form, it's now a <header> tag at the top.

  Changed Actions, Audit, Nonconformity and Review.
…installed if the audittrail module is installed.
* [FIX] Migration folder names
* label Poplicy n'est pas au bonne endroit
* [UPG] module manifest and views to v7 format
* [IMP] Add company_id and its default value
* [IMP] Add company_id in views
* [FIX] Missing object : review_line
* [IMP] mgmtsystem_*_security.xml files
* [FIX] PEP8 compliance after running flake8
Fix imports and replaced survey.responses by survey.user_input
Removed vim lines
[IMP] Add README.rst and data, views and models directories
Remove executable flag on python files and xml
Moved icon
[IMP] - mgmtsystem_review: Improved view and fixed typo.
[ADD] - mgmtsystem_review: Updated pot and added spanish translation.
[FIX] - mgmtsystem_review: Fixed translation template.
[REM] Migration files
[IMP] Description, version
[IMP] Add "Try me" button
[IMP] Remove osv
[FIX] Formatting in README.rst
[FIX] import models
[IMP] Migrate to new API
[FIX] AttributeError: 'module' object has no attribute 'Many2Many'
[FIX] Trailing comma after field definition
@pedrobaeza pedrobaeza force-pushed the 12.0-mig-mgmtsystem_review branch from 2d9b146 to 3d54a7f Compare August 12, 2019 18:24
@pedrobaeza
Copy link
Member

Rebased and squash commits.

/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Rebased to 12.0-ocabot-merge-pr-251-by-pedrobaeza-bump-no, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 3d54a7f into OCA:12.0 Aug 12, 2019
OCA-git-bot added a commit that referenced this pull request Aug 12, 2019
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d502c0c. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 12.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.