[14.0][CI] avoid suprious coverage changes #3114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvalyi
changed the title
marcelsavegnago
approved these changes
Jun 7, 2024
antoniospneto
approved these changes
Jun 7, 2024
renatonlima
approved these changes
Jun 7, 2024
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 348afaa. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
com esse PR o codecoverage ira deixar de monitorar o coverage 2 arquivos do cliente do IBPT e do cliente do Banco do Brasil. Como esses serviços tem problemas de vez enquando a gente optou por testar com o verdadeiro servidor apenas um certo dia da semana e testar apenas com mock o restante do tempo. Mas isso faz variar levamente o % de coverage desses arquivos e consequentemente deixa PRs validos em vermelhos porque o coverage baixou algo como 0.01%.
Eu acho melhor não monitorar mais o coverage destes 2 arquivos (que tem um coverage OK) e poder confiar se os PR são verdes ou vermelhos.
(exemplo https://app.codecov.io/gh/OCA/l10n-brazil/pull/3110/indirect-changes )