[14.0][MIG] resource_hook: Migration to 14.0 #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- hr_calendar_rest_time: Adds rest time to the calendar attendance records - resource_hook: Extends the resource with hooks to standard methods
Currently translated at 50.0% (1 of 2 strings) Translation: hr-13.0/hr-13.0-resource_hook Translate-URL: https://translation.odoo-community.org/projects/hr-13-0/hr-13-0-resource_hook/es/
Currently translated at 100.0% (2 of 2 strings) Translation: hr-13.0/hr-13.0-resource_hook Translate-URL: https://translation.odoo-community.org/projects/hr-13-0/hr-13-0-resource_hook/es/
Fix the validation of leaves
With module resource_hook installed the method
_get_work_hours_interval(start, stop, meta)
is called from a hr.employee (self) Object.
This is not implemented for hr.employee unless you do it by yourself
and Odoo crashes on second Approve.
Since a calendar object exists you can use calendar instead of self.
nimarosa
approved these changes
Feb 23, 2023
|
/ocabot merge nobump Merging 👍 thanks for the migration, I wanted to do it but never find the time. |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at add360d. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.